refactor(review): add private class property for indent size, move evaluation of this property to setOptions()

Author: shdq

Diff for: packages/logger/src/Logger.ts

@@ -125,6 +125,8 @@ class Logger extends Utility implements ClassThatLogs {
 
   private logFormatter?: LogFormatterInterface;
 
+  private logIndentation: number = LogJsonIndent.COMPACT;
+
   private logLevel?: LogLevel;
 
   private readonly logLevelThresholds: LogLevelThresholds = {
@@ -570,10 +572,7 @@ class Logger extends Utility implements ClassThatLogs {
 
     const consoleMethod = logLevel.toLowerCase() as keyof ClassThatLogs;
 
-    const isDevMode = this.getEnvVarsService().getDevMode();
-    const INDENTATION: LogJsonIndent = isDevMode ? LogJsonIndent.PRETTY : LogJsonIndent.COMPACT;
-
-    this.console[consoleMethod](JSON.stringify(log.getAttributes(), this.removeCircularDependencies(), INDENTATION));
+    this.console[consoleMethod](JSON.stringify(log.getAttributes(), this.removeCircularDependencies(), this.logIndentation));
   }
 
   /**
@@ -666,6 +665,19 @@ class Logger extends Utility implements ClassThatLogs {
     this.logFormatter = logFormatter || new PowertoolLogFormatter();
   }
 
+  /**
+   * If the `POWERTOOLS_DEV' env variable is set,
+   * it adds JSON indentation for pretty printing logs.
+   *
+   * @private
+   * @returns {void}
+   */
+  private setLogIndentation(): void {
+    if (this.getEnvVarsService().getDevMode()) {
+      this.logIndentation = LogJsonIndent.PRETTY;
+    }
+  }
+
   /**
    * It sets the Logger's instance log level.
    *
@@ -735,6 +747,7 @@ class Logger extends Utility implements ClassThatLogs {
     this.setLogFormatter(logFormatter);
     this.setPowertoolLogData(serviceName, environment);
     this.setLogEvent();
+    this.setLogIndentation();
 
     this.addPersistentLogAttributes(persistentLogAttributes);