Skip to content

Commit 67c4b98

Browse files
authored
chore(ci): phase out aws-sdk usage (#1405)
* chore: removed aws sdk v2 from tests and other places * chore: removed aws-sdk v2 from cdk example * chore: bump dev dep * chore: fixed sam example * chore: temporarily removed compatible arch from layer
1 parent e880860 commit 67c4b98

22 files changed

+7068
-864
lines changed

Diff for: docs/snippets/package.json

+1
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
"@aws-sdk/client-secrets-manager": "^3.250.0",
3333
"@aws-sdk/client-ssm": "^3.245.0",
3434
"@aws-sdk/util-dynamodb": "^3.245.0",
35+
"aws-sdk": "^2.1354.0",
3536
"aws-sdk-client-mock": "^2.0.1",
3637
"aws-sdk-client-mock-jest": "^2.0.1",
3738
"axios": "^1.2.4"

Diff for: examples/cdk/functions/get-all-items.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ const getAllItemsHandler = async (event: APIGatewayProxyEvent, context: Context)
6767

6868
// Logger: All log statements are written to CloudWatch
6969
logger.debug(`retrieved items: ${items?.length || 0}`);
70-
70+
7171
logger.info(`Response ${event.path}`, {
7272
statusCode: 200,
7373
body: items,
@@ -80,7 +80,7 @@ const getAllItemsHandler = async (event: APIGatewayProxyEvent, context: Context)
8080
} catch (err) {
8181
tracer.addErrorAsMetadata(err as Error);
8282
logger.error('Error reading from table. ' + err);
83-
83+
8484
return {
8585
statusCode: 500,
8686
body: JSON.stringify({ 'error': 'Error reading from table.' })

Diff for: examples/cdk/functions/get-by-id.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -79,24 +79,24 @@ class Lambda implements LambdaInterface {
7979
const data = await docClient.send(new GetCommand({
8080
TableName: tableName,
8181
Key: {
82-
id: event.pathParameters.id
82+
id: event.pathParameters.id
8383
}
8484
}));
8585
const item = data.Item;
86-
86+
8787
logger.info(`Response ${event.path}`, {
8888
statusCode: 200,
8989
body: item,
9090
});
91-
91+
9292
return {
9393
statusCode: 200,
9494
body: JSON.stringify(item)
9595
};
9696
} catch (err) {
9797
tracer.addErrorAsMetadata(err as Error);
9898
logger.error('Error reading from table. ' + err);
99-
99+
100100
return {
101101
statusCode: 500,
102102
body: JSON.stringify({ 'error': 'Error reading from table.' })

Diff for: examples/cdk/functions/put-item.ts

+14-8
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import { logger, tracer, metrics } from './common/powertools';
44
import { docClient } from './common/dynamodb-client';
55
import { PutCommand } from '@aws-sdk/lib-dynamodb';
66
import { default as request } from 'phin';
7+
import type { Subsegment } from 'aws-xray-sdk-core';
78

89
/**
910
*
@@ -28,8 +29,11 @@ export const handler = async (event: APIGatewayProxyEvent, context: Context): Pr
2829
const segment = tracer.getSegment();
2930

3031
// Tracer: Create subsegment for the function & set it as active
31-
const handlerSegment = segment.addNewSubsegment(`## ${process.env._HANDLER}`);
32-
tracer.setSegment(handlerSegment);
32+
let handlerSegment: Subsegment | undefined;
33+
if (segment) {
34+
handlerSegment = segment.addNewSubsegment(`## ${process.env._HANDLER}`);
35+
tracer.setSegment(handlerSegment);
36+
}
3337

3438
// Tracer: Annotate the subsegment with the cold start & serviceName
3539
tracer.annotateColdStart();
@@ -79,7 +83,7 @@ export const handler = async (event: APIGatewayProxyEvent, context: Context): Pr
7983
await docClient.send(new PutCommand({
8084
TableName: tableName,
8185
Item: {
82-
id,
86+
id,
8387
name
8488
}
8589
}));
@@ -96,15 +100,17 @@ export const handler = async (event: APIGatewayProxyEvent, context: Context): Pr
96100
} catch (err) {
97101
tracer.addErrorAsMetadata(err as Error);
98102
logger.error('Error writing data to table. ' + err);
99-
103+
100104
return {
101105
statusCode: 500,
102106
body: JSON.stringify({ 'error': 'Error writing data to table.' })
103107
};
104108
} finally {
105-
// Tracer: Close subsegment (the AWS Lambda one is closed automatically)
106-
handlerSegment.close(); // (## index.handler)
107-
// Tracer: Set the facade segment as active again (the one created by AWS Lambda)
108-
tracer.setSegment(segment);
109+
if (segment && handlerSegment) {
110+
// Tracer: Close subsegment (the AWS Lambda one is closed automatically)
111+
handlerSegment.close(); // (## index.handler)
112+
// Tracer: Set the facade segment as active again (the one created by AWS Lambda)
113+
tracer.setSegment(segment);
114+
}
109115
}
110116
};

0 commit comments

Comments
 (0)