feat: branch coverage and cleaning up imports

Author: jeffrey-baker-vg

packages/idempotency/src/persistence/DynamoDbPersistenceLayer.ts

@@ -1,5 +1,6 @@
 /* eslint-disable @typescript-eslint/no-empty-function */
-import { IdempotencyRecord, PersistenceLayer } from './PersistenceLayer';
+import { PersistenceLayer } from './PersistenceLayer';
+import { IdempotencyRecord } from './IdempotencyRecord';
 
 class DynamoDBPersistenceLayer extends PersistenceLayer {
   public constructor(_tableName: string, _key_attr: string = 'id') {

packages/idempotency/src/persistence/PersistenceLayer.ts

@@ -125,6 +125,5 @@ abstract class PersistenceLayer implements PersistenceLayerInterface {
 }
 
 export {
-  IdempotencyRecord,
   PersistenceLayer
 };

packages/idempotency/src/persistence/PersistenceLayerInterface.ts

@@ -1,4 +1,4 @@
-import { IdempotencyRecord } from './PersistenceLayer';
+import { IdempotencyRecord } from './IdempotencyRecord';
 
 interface PersistenceLayerInterface {
   configure(functionName: string): void

packages/idempotency/tests/unit/PersistenceLayer.test.ts

@@ -80,6 +80,29 @@ describe('Class: Persistence Layer', ()=> {
       expect(savedIdempotencyRecord.idempotencyKey).toEqual(expectedIdempotencyKey);
     });
 
+    test('When called without a function name it creates an idempotency key from the Lambda name only and a digest of the md5 hash of the data', async ()=> {
+      const data = 'someData';
+      const lambdaFunctionName = 'LambdaName';
+      jest.spyOn(EnvironmentVariablesService.prototype, 'getLambdaFunctionName').mockReturnValue(lambdaFunctionName);
+
+      const expectedIdempotencyKey = lambdaFunctionName + '.' + '#' + mockDigest;
+      const persistenceLayer: PersistenceLayer = new PersistenceLayerTestClass();
+      persistenceLayer.configure();
+
+      await persistenceLayer.saveInProgress(data);
+
+      const savedIdempotencyRecord: IdempotencyRecord = putRecord.mock.calls[0][0];
+
+      expect(createHash).toHaveBeenCalledWith(
+        expect.stringMatching('md5'),
+      );
+      expect(cryptoUpdateMock).toHaveBeenCalledWith(expect.stringMatching(data));
+      expect(cryptoDigestMock).toHaveBeenCalledWith(
+        expect.stringMatching('base64')
+      );
+      expect(savedIdempotencyRecord.idempotencyKey).toEqual(expectedIdempotencyKey);
+    });
+
     test('When called it sets the expiry timestamp to one hour in the future', async ()=> {
       const persistenceLayer: PersistenceLayer = new PersistenceLayerTestClass();
       const data = 'someData';