Skip to content

Commit 2c3df93

Browse files
authored
fix(all): fix latest release broken by change of npm pack result on common (#470)
* Revert "fix(build): Update contributing.md and fix npm ci (#417)" This reverts commit 279ad98. * revert commons version
1 parent d6aae13 commit 2c3df93

11 files changed

+13
-31
lines changed

Diff for: CONTRIBUTING.md

+4-6
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ Please read through this document before submitting any issues or pull requests
77
information to effectively respond to your bug report or contribution.
88

99
## Security issue notifications
10-
1110
If you discover a potential security issue in this project we ask that you notify AWS/Amazon Security via our [vulnerability reporting page](http://aws.amazon.com/security/vulnerability-reporting/). Please do **not** create a public GitHub issue.
1211

1312
## Reporting Bugs/Feature Requests
@@ -36,7 +35,7 @@ Contributions via pull requests are much appreciated. Before sending us a pull r
3635
To send us a pull request, please follow these steps:
3736

3837
1. Fork the repository.
39-
2. Install dependencies: `npm ci`
38+
2. Install dependencies: `npm install`
4039
3. Prepare utilities like commit hooks: `npm run init-environment`
4140
4. Create a new branch to focus on the specific change you are contributing e.g. `git checkout -b improv/logger-debug-sampling`
4241
5. Run all tests, and code baseline checks: `npm run test`
@@ -55,9 +54,8 @@ You might find useful to run both the documentation website and the API referenc
5554
* **Docs website**:
5655

5756
You can build and start a local docs website by running these two commands.
58-
59-
* `npm run docs-buildDockerImage` OR `docker build -t squidfunk/mkdocs-material ./docs/`
60-
* `npm run docs-runLocalDocker` OR `docker run --rm -it -p 8000:8000 -v ${PWD}:/docs squidfunk/mkdocs-material`
57+
- `npm run docs-buildDockerImage` OR `docker build -t squidfunk/mkdocs-material ./docs/`
58+
- `npm run docs-runLocalDocker` OR `docker run --rm -it -p 8000:8000 -v ${PWD}:/docs squidfunk/mkdocs-material`
6159

6260
### Tests
6361

@@ -181,4 +179,4 @@ TODO
181179

182180
See the [LICENSE](LICENSE) file for our project's licensing. We will ask you to confirm the licensing of your contribution.
183181

184-
We may ask you to sign a [Contributor License Agreement (CLA)](http://en.wikipedia.org/wiki/Contributor_License_Agreement) for larger changes.
182+
We may ask you to sign a [Contributor License Agreement (CLA)](http://en.wikipedia.org/wiki/Contributor_License_Agreement) for larger changes.

Diff for: packages/commons/tsconfig.json

-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
{
22
"compilerOptions": {
3-
"composite": true,
43
"experimentalDecorators": true,
54
"noImplicitAny": true,
65
"target": "ES2020",

Diff for: packages/logger/package-lock.json

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: packages/logger/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@
7171
"url": "https://github.com/awslabs/aws-lambda-powertools-typescript/issues"
7272
},
7373
"dependencies": {
74-
"@aws-lambda-powertools/commons": "^0.3.0",
74+
"@aws-lambda-powertools/commons": "^0.2.0",
7575
"@middy/core": "^2.5.3",
7676
"@types/aws-lambda": "^8.10.72",
7777
"lodash.clonedeep": "^4.5.0",

Diff for: packages/logger/tsconfig.json

-5
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,5 @@
2626
"types": [
2727
"jest",
2828
"node"
29-
],
30-
"references": [
31-
{
32-
"path": "../commons"
33-
}
3429
]
3530
}

Diff for: packages/metrics/package-lock.json

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: packages/metrics/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@
8484
"url": "https://github.com/awslabs/aws-lambda-powertools-typescript/issues"
8585
},
8686
"dependencies": {
87-
"@aws-lambda-powertools/commons": "^0.3.0",
87+
"@aws-lambda-powertools/commons": "^0.2.0",
8888
"@types/aws-lambda": "^8.10.72"
8989
}
9090
}

Diff for: packages/metrics/tsconfig.json

-5
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,5 @@
2828
"types": [
2929
"jest",
3030
"node"
31-
],
32-
"references": [
33-
{
34-
"path": "../commons"
35-
}
3631
]
3732
}

Diff for: packages/tracing/package-lock.json

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: packages/tracing/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@
6262
"url": "https://github.com/awslabs/aws-lambda-powertools-typescript/issues"
6363
},
6464
"dependencies": {
65-
"@aws-lambda-powertools/commons": "^0.3.0",
65+
"@aws-lambda-powertools/commons": "^0.2.0",
6666
"@middy/core": "^2.5.3",
6767
"aws-xray-sdk-core": "^3.3.3"
6868
}

Diff for: packages/tracing/tsconfig.json

-5
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,5 @@
2828
"types": [
2929
"jest",
3030
"node"
31-
],
32-
"references": [
33-
{
34-
"path": "../commons"
35-
}
3631
]
3732
}

0 commit comments

Comments
 (0)