fix: version command refactor

Author: saragerion

.github/workflows/pr-run-linting-check-and-unit-tests.yml

@@ -0,0 +1,8 @@
+name: On PR code update
+
+on:
+  pull_request:
+    types: [opened, synchronize]
+jobs:
+  run-linting-check-and-unit-tests:
+    uses: ./.github/workflows/reusable-run-linting-check-and-unit-tests.yml

.github/workflows/pr_lint_and_test.yml

@@ -4,7 +4,7 @@ on:
   workflow_call:
 
 jobs:
-  run-unit-tests-on-utils:
+  run-linting-check-and-unit-tests:
     runs-on: ubuntu-latest
     env:
       NODE_ENV: dev
@@ -43,7 +43,7 @@ jobs:
         run: |
           npm run build -w packages/commons
           npm run build -w packages/logger & npm run build -w packages/tracer & npm run build -w packages/metrics
-      - name: Lint
+      - name: Run linting
         run: npm run lint -w packages/commons -w packages/logger -w packages/tracer -w packages/metrics
       - name: Run unit tests
         run: npm t -w packages/commons -w packages/logger -w packages/tracer -w packages/metrics
@@ -80,6 +80,8 @@ jobs:
         # We can skip the install if there was a cache hit
         if: steps.cache-node-modules.outputs.cache-hit != 'true'
         run: npm ci
+      - name: Run linting
+        run: npm run lint
       - name: Run tests
         run: npm t
   check-layer-publisher:
@@ -108,3 +110,5 @@ jobs:
         # We can skip the install if there was a cache hit
         if: steps.cache-node-modules.outputs.cache-hit != 'true'
         run: npm ci
+      - name: Run linting
+        run: npm run lint

.github/workflows/reusable-run-unit-tests.yml renamed to .github/workflows/reusable-run-linting-check-and-unit-tests.yml

@@ -1,5 +1,4 @@
 #!/bin/sh
 . "$(dirname "$0")/_/husky.sh"
 
-npm run lerna-lint-fix
 npm run test

.husky/pre-push

@@ -15,20 +15,17 @@
     "test": "npm run lerna-test",
     "commit": "commit",
     "package": "npm run package",
-    "setup-local": "npm ci --foreground-scripts && cd examples/cdk && npm ci && cd ../.. && cd examples/sam && npm ci && cd ../.. && npm run init-environment",
+    "setup-local": "npm ci --foreground-scripts && cd examples/cdk && npm ci && cd ../../examples/sam && npm ci && cd ../../layer-publisher && npm ci && cd ../.. && npm run init-environment",
     "lerna-test": "lerna exec -- npm run test",
     "lerna-test:unit": "lerna exec -- npm run test:unit",
     "lerna-test:e2e": "lerna exec -- npm run test:e2e",
     "lerna-package": "lerna exec -- npm run package",
     "lerna-package-bundle": "lerna exec -- npm run package-bundle",
-    "lerna-build": "lerna exec -- tsc",
+    "lerna-build": "lerna exec -- npm run build",
     "lerna-lint": "lerna exec -- npm run lint",
     "lerna-lint-fix": "lerna exec -- npm run lint-fix",
     "lerna-prepare": "lerna exec -- npm run build",
-    "lerna-prepublishOnly": "lerna exec -- npm test && lerna exec -- npm run lint",
-    "lerna-preversion": "lerna exec -- npm run lint",
-    "lerna-version": "lerna exec -- npm run lint-fix && git add -A src",
-    "postversion": "git push && git push --tags",
+    "postversion": "git push --tags",
     "docs-website-build-run": "npm run docs-buildDockerImage && npm run docs-runLocalDocker",
     "docs-buildDockerImage": "docker build -t powertool-typescript/docs ./docs/",
     "docs-runLocalDocker": "docker run --rm -it -p 8000:8000 -v ${PWD}:/docs powertool-typescript/docs",

package.json

@@ -21,10 +21,7 @@
     "package": "mkdir -p dist/ && npm pack && mv *.tgz dist/",
     "package-bundle": "../../package-bundler.sh commons-bundle ./dist",
     "prepare": "npm run build",
-    "prepublishOnly": "npm test && npm run lint",
-    "preversion": "npm run lint",
-    "version": "npm run lint-fix && git add -A src",
-    "postversion": "git push && git push --tags"
+    "postversion": "git push --tags"
   },
   "homepage": "https://github.com/awslabs/aws-lambda-powertools-typescript/tree/master/packages/metrics#readme",
   "license": "MIT-0",
@@ -48,4 +45,4 @@
     "serverless",
     "nodejs"
   ]
-}
+}

packages/commons/package.json

@@ -24,10 +24,7 @@
     "package": "mkdir -p dist/ && npm pack && mv *.tgz dist/",
     "package-bundle": "../../package-bundler.sh logger-bundle ./dist",
     "prepare": "npm run build",
-    "prepublishOnly": "npm test && npm run lint",
-    "preversion": "npm run lint",
-    "version": "npm run lint-fix && git add -A src",
-    "postversion": "git push && git push --tags"
+    "postversion": "git push --tags"
   },
   "homepage": "https://github.com/awslabs/aws-lambda-powertools-typescript/tree/master/packages/idempotency#readme",
   "license": "MIT",

packages/idempotency/package.json

@@ -24,10 +24,7 @@
     "package": "mkdir -p dist/ && npm pack && mv *.tgz dist/",
     "package-bundle": "../../package-bundler.sh logger-bundle ./dist",
     "prepare": "npm run build",
-    "prepublishOnly": "npm test && npm run lint",
-    "preversion": "npm run lint",
-    "version": "npm run lint-fix && git add -A src",
-    "postversion": "git push && git push --tags"
+    "postversion": "git push --tags"
   },
   "homepage": "https://github.com/awslabs/aws-lambda-powertools-typescript/tree/master/packages/logging#readme",
   "license": "MIT",
@@ -64,4 +61,4 @@
     "serverless",
     "nodejs"
   ]
-}
+}

packages/logger/package.json

@@ -24,10 +24,7 @@
     "package": "mkdir -p dist/ && npm pack && mv *.tgz dist/",
     "package-bundle": "../../package-bundler.sh metrics-bundle ./dist",
     "prepare": "npm run build",
-    "prepublishOnly": "npm test && npm run lint",
-    "preversion": "npm run lint",
-    "version": "npm run lint-fix && git add -A src",
-    "postversion": "git push && git push --tags"
+    "postversion": "git push --tags"
   },
   "homepage": "https://github.com/awslabs/aws-lambda-powertools-typescript/tree/master/packages/metrics#readme",
   "license": "MIT-0",
@@ -59,4 +56,4 @@
     "serverless",
     "nodejs"
   ]
-}
+}

packages/metrics/package.json

@@ -22,10 +22,7 @@
     "lint": "eslint --ext .ts --no-error-on-unmatched-pattern src tests",
     "lint-fix": "eslint --fix --ext .ts --no-error-on-unmatched-pattern src tests",
     "prepare": "npm run build",
-    "prepublishOnly": "npm test && npm run lint",
-    "preversion": "npm run lint",
-    "version": "npm run lint-fix && git add -A src",
-    "postversion": "git push && git push --tags",
+    "postversion": "git push --tags",
     "package": "mkdir -p dist/ && npm pack && mv *.tgz dist/",
     "package-bundle": "../../package-bundler.sh tracer-bundle ./dist"
   },
@@ -62,4 +59,4 @@
     "serverless",
     "nodejs"
   ]
-}
+}