Skip to content

feat: Add Kinesis lambda event support to Parser utility #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 4, 2020
Merged

feat: Add Kinesis lambda event support to Parser utility #227

merged 6 commits into from
Dec 4, 2020

Conversation

ran-isenberg
Copy link
Contributor

feat: Add Kinesis lambda event support to Parser utility #226

This adds automatic base64 decode in the schema.

@heitorlessa heitorlessa added area/utilities feature New feature or functionality labels Dec 1, 2020
@heitorlessa heitorlessa self-assigned this Dec 1, 2020
heitorlessa
heitorlessa suggested changes Dec 1, 2020
View reviewed changes
Copy link
Contributor

@heitorlessa heitorlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks clean enough and specially the pre-validation piece :)

One additional ask as with other PRs:

  1. Could you please update the model and envelope docs?

https://github.com/awslabs/aws-lambda-powertools-python/blob/develop/docs/content/utilities/parser.mdx#extending-built-in-models

https://github.com/awslabs/aws-lambda-powertools-python/blob/develop/docs/content/utilities/parser.mdx#built-in-envelopes

heitorlessa
heitorlessa reviewed Dec 1, 2020
View reviewed changes
Copy link
Contributor

@heitorlessa heitorlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding additional comments to commit later on renaming Kinesis with KinesisDataStream to allow expansion with other products

@heitorlessa
Copy link
Contributor

heitorlessa commented Dec 1, 2020 •
edited
Loading

thanks a lot as always @risenberg-cyberark - As discussed, I'll commit these suggestions, and will try pushing the docs to your branch then merge. Failing that, I'll merge as-is, then send another PR with docs and suggestions implemented ;)

ETA: This Friday EOD

@codecov-io
Copy link

codecov-io commented Dec 1, 2020 •
edited
Loading

Codecov Report

Merging #227 (9b55817) into develop (fa34d82) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #227   +/-   ##
========================================
  Coverage    99.88%   99.88%           
========================================
  Files           70       72    +2     
  Lines         2600     2649   +49     
  Branches       109      110    +1     
========================================
+ Hits          2597     2646   +49     
  Misses           3        3
Impacted Files Coverage Δ
..._powertools/utilities/parser/envelopes/__init__.py 100.00% <100.00%> (ø)
...a_powertools/utilities/parser/envelopes/kinesis.py 100.00% <100.00%> (ø)
...bda_powertools/utilities/parser/models/__init__.py 100.00% <100.00%> (ø)
...mbda_powertools/utilities/parser/models/kinesis.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa34d82...9b55817. Read the comment docs.

@heitorlessa
Merge branch 'develop' into kinesis
c822713 
* develop:
  docs: add S3 as a supported model
  docs: add CW Logs as a supported envelope
  fix: cloudwatch logs envelope typo
  docs: add CW Logs as a supported model
  docs: add Alb as a supported model
  docs: shadow sidebar to remain expanded
  cr fixes
  feat: Add cloudwatch lambda event support to Parser utility
  feat: Add alb lambda event support to Parser utility #228
  feat: Add S3 lambda event support to Parser utility #224
@heitorlessa
docs: add Kinesis Streams as a supported model & envelope
3809763
heitorlessa
heitorlessa approved these changes Dec 4, 2020
View reviewed changes
Copy link
Contributor

@heitorlessa heitorlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs added - Merging

@heitorlessa heitorlessa merged commit ee18f83 into aws-powertools:develop Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heitorlessa heitorlessa heitorlessa approved these changes

Assignees

@heitorlessa heitorlessa

Labels
feature New feature or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ran-isenberg @heitorlessa @codecov-io