-
Notifications
You must be signed in to change notification settings - Fork 421
fix(license): add MIT-0 license header #1871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
Hey @meckhardt, thank you for the proactive addition. Could you share some background on how you bumped into this? All of our PRs need an issue (a maintenance issue template in this case) in order to be merged. We'll check with our OSPO on the appropriate outcome for the |
Hopping on the OSPO side. The title is an optional field ( https://spdx.org/licenses/MIT-0.json ), but it is embarrassing that our predating OSI-approval template didn't include the title. I'm +1 to merge this PR. It's not necessary, as that field is optional, but I'm going to suggest we update our template to start defaulting to include the title. |
Thanks @heitorlessa @hyandell that you take this change seriously. I had an issue with Sonatype Nexus IQ about MIT-0 being recognized as a proprietary license which led to a rejected build for one of my customers. While searching for the root cause @fabge found a difference between the license text given on https://en.wikipedia.org/wiki/MIT_License#MIT_No_Attribution_License and https://github.com/aws/mit-0. Sonatype Support states that this shouldn't be an issue with their recent Nexus IQ release. However, I wanted to share this finding with you. |
I added #1881 |
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Issue number: #1881
Changes
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
No.RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.