Skip to content

fix(license): add MIT-0 license header #1871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 1, 2023

Conversation

e42sh
Copy link

@e42sh e42sh commented Jan 30, 2023

Issue number: #1881

Changes

User experience

  • No impact

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change? No.

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@e42sh e42sh requested a review from a team as a code owner January 30, 2023 12:08
@e42sh e42sh requested review from heitorlessa and removed request for a team January 30, 2023 12:08
@boring-cyborg boring-cyborg bot added the internal Maintenance changes label Jan 30, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 30, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 30, 2023

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #python channel on our AWS Lambda Powertools Discord: Invite link

@rubenfonseca rubenfonseca added the need-issue PRs that are missing related issues label Jan 30, 2023
@heitorlessa heitorlessa self-assigned this Jan 31, 2023
@heitorlessa
Copy link
Contributor

Hey @meckhardt, thank you for the proactive addition. Could you share some background on how you bumped into this?

All of our PRs need an issue (a maintenance issue template in this case) in order to be merged. We'll check with our OSPO on the appropriate outcome for the LICENSE file.

@hyandell
Copy link

Hopping on the OSPO side. The title is an optional field ( https://spdx.org/licenses/MIT-0.json ), but it is embarrassing that our predating OSI-approval template didn't include the title.

I'm +1 to merge this PR. It's not necessary, as that field is optional, but I'm going to suggest we update our template to start defaulting to include the title.

@e42sh
Copy link
Author

e42sh commented Feb 1, 2023

Thanks @heitorlessa @hyandell that you take this change seriously.

I had an issue with Sonatype Nexus IQ about MIT-0 being recognized as a proprietary license which led to a rejected build for one of my customers. While searching for the root cause @fabge found a difference between the license text given on https://en.wikipedia.org/wiki/MIT_License#MIT_No_Attribution_License and https://github.com/aws/mit-0. Sonatype Support states that this shouldn't be an issue with their recent Nexus IQ release. However, I wanted to share this finding with you.

@e42sh
Copy link
Author

e42sh commented Feb 1, 2023

I added #1881

@heitorlessa heitorlessa changed the title fix(LICENSE) - Add MIT-0 license header fix(license): add MIT-0 license header Feb 1, 2023
@heitorlessa heitorlessa merged commit bc3d046 into aws-powertools:develop Feb 1, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 1, 2023

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

@github-actions github-actions bot added the bug Something isn't working label Feb 1, 2023
@e42sh e42sh deleted the patch-1 branch February 1, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal Maintenance changes need-issue PRs that are missing related issues size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants