Skip to content

chore(multiple): localize powertools_dev env logic and warning #1570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 5, 2022
Merged

chore(multiple): localize powertools_dev env logic and warning #1570

merged 7 commits into from
Oct 5, 2022

Conversation

heitorlessa
Copy link
Contributor

@heitorlessa heitorlessa commented Oct 4, 2022 •
edited
Loading

Issue number: #1527

Documentation being updated in #1569

Summary

Changes

Please provide a summary of what's being changed

  • Localize logic for the new POWERTOOLS_DEV to ease adopting in other utilities later
  • Add support for POWERTOOLS_DEV in Event Handler

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@heitorlessa heitorlessa requested a review from a team as a code owner October 4, 2022 16:44
@heitorlessa heitorlessa requested review from mploski and removed request for a team October 4, 2022 16:44
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 4, 2022
@heitorlessa heitorlessa requested review from leandrodamascena and removed request for mploski October 4, 2022 16:44
@heitorlessa heitorlessa self-assigned this Oct 4, 2022
@github-actions github-actions bot added the internal Maintenance changes label Oct 4, 2022
leandrodamascena
leandrodamascena previously requested changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made two suggestions. I executed it locally and in Lambda and it worked as expected.
Please check if it make sense.

@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Oct 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2022 •
edited
Loading

Codecov Report

Base: 99.73% // Head: 99.74% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (38598d3) compared to base (9545f69).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 38598d3 differs from pull request most recent head 0006417. Consider uploading reports for the commit 0006417 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #1570   +/-   ##
========================================
  Coverage    99.73%   99.74%           
========================================
  Files          124      124           
  Lines         5731     5771   +40     
  Branches       653      656    +3     
========================================
+ Hits          5716     5756   +40     
  Misses           8        8           
  Partials         7        7
Impacted Files Coverage Δ
aws_lambda_powertools/event_handler/api_gateway.py 100.00% <100.00%> (ø)
aws_lambda_powertools/logging/formatter.py 100.00% <100.00%> (ø)
aws_lambda_powertools/shared/constants.py 100.00% <100.00%> (ø)
aws_lambda_powertools/shared/functions.py 88.57% <100.00%> (+3.38%) ⬆️
aws_lambda_powertools/event_handler/appsync.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@heitorlessa heitorlessa dismissed leandrodamascena’s stale review October 5, 2022 07:49

addressed Leandro's comments and he's OOTO today.

@heitorlessa heitorlessa merged commit 9000e6b into aws-powertools:develop Oct 5, 2022
@heitorlessa heitorlessa deleted the feat/increase-powertools-dev-coverage branch October 5, 2022 07:55
@heitorlessa
Copy link
Contributor Author

I made two suggestions. I executed it locally and in Lambda and it worked as expected. Please check if it make sense.

Thanks a lot for the useful suggestions!

@heitorlessa heitorlessa mentioned this pull request Oct 5, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandrodamascena leandrodamascena leandrodamascena left review comments

Assignees

@heitorlessa heitorlessa

Labels
documentation Improvements or additions to documentation internal Maintenance changes size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heitorlessa @codecov-commenter @leandrodamascena