Skip to content

Docs: Addition of docs inventory (objects.inv) #5125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
JP-Ellis opened this issue Sep 5, 2024 · 7 comments
Closed
1 task done

Docs: Addition of docs inventory (objects.inv) #5125

JP-Ellis opened this issue Sep 5, 2024 · 7 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@JP-Ellis
Copy link

JP-Ellis commented Sep 5, 2024

What were you searching in the docs?

I am documenting a repository which uses AWS Powertools for Lambda, using MkDocs. In general, it is possible to import inventories of other packages so that when the documentation is generated, links can go out to the relevant docs sites.

Examples include:

  • https://docs.aiohttp.org/en/stable/objects.inv
  • https://docs.pydantic.dev/latest/objects.inv
  • https://docs.python.org/3/objects.inv

It would appear that the AWS Powertools for Lambda documentation does not generate/include the inventory file

Is this related to an existing documentation section?

No response

How can we improve?

By ensuring that the file is available at its standard location (e.g. https://docs.powertools.aws.dev/lambda/python/latest/object.inv), or to document where it is being published.

Got a suggestion in mind?

No response

Acknowledgment

  • I understand the final update might be different from my proposed suggestion, or refused.
@JP-Ellis JP-Ellis added documentation Improvements or additions to documentation triage Pending triage from maintainers labels Sep 5, 2024
Copy link

boring-cyborg bot commented Sep 5, 2024

Thanks for opening your first issue here! We'll come back to you as soon as we can.
In the meantime, check out the #python channel on our Powertools for AWS Lambda Discord: Invite link

@leandrodamascena
Copy link
Contributor

Hi @JP-Ellis! Thanks for letting us know this exists, I had no idea about it and it looks like a great feature.

I'm trying to see how mkdocs implement this and how we can use this in Powertools. If you have any ideas and can share, I would really appreciate it.

@leandrodamascena leandrodamascena self-assigned this Sep 5, 2024
@leandrodamascena leandrodamascena removed the triage Pending triage from maintainers label Sep 5, 2024
@leandrodamascena leandrodamascena moved this from Triage to Backlog in Powertools for AWS Lambda (Python) Sep 5, 2024
@JP-Ellis
Copy link
Author

JP-Ellis commented Sep 5, 2024

MkDocs on its own is just for displaying Markdown files, but the mkdocstrings plugin is really useful to parse and convert the docstrings from the Python code into documentation and (importantly) an inventory file.

I'll see about making a little PoC over the weekend 🙂

@leandrodamascena
Copy link
Contributor

MkDocs on its own is just for displaying Markdown files, but the mkdocstrings plugin is really useful to parse and convert the docstrings from the Python code into documentation and (importantly) an inventory file.

I'll see about making a little PoC over the weekend 🙂

Ohh, great! We're trying to use mkdocstrings to create new documentation for the Parser and Event Source Data Classes, but it looks like we need a major refactoring in some parts of the documentation.

Please let me know if you need help with this PoC, we're very interested in adopting mkdocstrings.

@leandrodamascena leandrodamascena added the help wanted Could use a second pair of eyes/hands label Sep 5, 2024
@leandrodamascena leandrodamascena linked a pull request Sep 9, 2024 that will close this issue
5 tasks
@dreamorosi
Copy link
Contributor

dreamorosi commented Jan 28, 2025

We're working on replacing pdoc3 with mkdocstrings which should handle the creation of the objects.inv file automatically.

You can track status here #4632. We'll also report back here once we're done.

@dreamorosi dreamorosi moved this from Ideas to Working on it in Powertools for AWS Lambda (Python) Jan 28, 2025
@leandrodamascena leandrodamascena removed the help wanted Could use a second pair of eyes/hands label Feb 2, 2025
@leandrodamascena leandrodamascena moved this from Working on it to Next iteration in Powertools for AWS Lambda (Python) Feb 2, 2025
@leandrodamascena leandrodamascena moved this from Next iteration to Working on it in Powertools for AWS Lambda (Python) Feb 2, 2025
@leandrodamascena
Copy link
Contributor

We've successfully migrated our API documentation to mkdocstrings. While we might need to fine-tune things based on customer feedback in the future, we're now exposing almost all public components. Compared to pdoc3, this new plugin is significantly more user-friendly and I really liked it.

The new documentation and inventory will be published on our next release, what is expected for 11/02.

Closing this issue as complete.

@github-project-automation github-project-automation bot moved this from Working on it to Coming soon in Powertools for AWS Lambda (Python) Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@leandrodamascena leandrodamascena moved this from Coming soon to Shipped in Powertools for AWS Lambda (Python) Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Shipped
Development

Successfully merging a pull request may close this issue.

3 participants