-
Notifications
You must be signed in to change notification settings - Fork 421
Bug: KafkaEventRecord Incorrect types for offset and partition properties #4504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for opening your first issue here! We'll come back to you as soon as we can. |
Hi @scampbell5! Thanks for pointing out this bug. Actually, you're 100% right, these fields should be References: |
@leandrodamascena Appreciate the quick response! I'll work on putting together a PR later tonight to fix this. |
Perfect, let me know if you have any questions or blocks, and we can work together on this! We truly appreciate when the community contributes to the project. 🚀 |
@leandrodamascena I've submitted this PR if you don't mind taking a look when you have time: #4515 |
|
Expected Behaviour
The properties for
offset
andpartition
are the correctint
type on theKafkaEventRecord
class.Current Behaviour
The properties for
offset
andpartition
on theKafkaEventRecord
are currently defined asstr
type.Code snippet
https://github.com/aws-powertools/powertools-lambda-python/blob/develop/aws_lambda_powertools/utilities/data_classes/kafka_event.py#L18
Possible Solution
Change the type to
int
for thepartition
andoffset
properties on theKafkaEventRecord
class.Steps to Reproduce
Powertools for AWS Lambda (Python) version
latest
AWS Lambda function runtime
3.11
Packaging format used
Lambda Layers
Debugging logs
No response
The text was updated successfully, but these errors were encountered: