Bug: POWERTOOLS_IDEMPOTENCY_DISABLED does not respect truthy values

[stevenhoelscher]

Expected Behaviour

I would expect truthy values to be respected for POWERTOOLS_IDEMPOTENCY_DISABLED:

• True: ["1", "y", "yes", "t", "true", "on"]
• False: ["0": "n", "no", "f", "false", "off"]

Current Behaviour

The logic below is accessing the environment variable and bypassing the idempotency layer if it the condition evaluates to True. But it's always evaluating to True unless os.getenv returns None.

if os.getenv(constants.IDEMPOTENCY_DISABLED_ENV):
    return function(*args, **kwargs)

Code snippet

>>> import os
>>> os.environ['POWERTOOLS_IDEMPOTENCY_DISABLED'] = 'false'
>>> bool(os.getenv('POWERTOOLS_IDEMPOTENCY_DISABLED'))
True
>>> bool(None)
False

Possible Solution

Leverage the strtobool function in aws_lambda_powertools.shared.functions to convert the environment variable value into a bool.

Steps to Reproduce

I would recommend setting the value of POWERTOOLS_IDEMPOTENCY_DISABLED to false, which implies the user does not want idempotency to be disabled. In this situation, the Idempotency layer will be bypassed and no records will be recorded in the idempotency store.

Powertools for AWS Lambda (Python) version

latest

AWS Lambda function runtime

3.11

Packaging format used

Lambda Layers

Debugging logs

No response

[boring-cyborg]

Thanks for opening your first issue here! We'll come back to you as soon as we can.
In the meantime, check out the #python channel on our Powertools for AWS Lambda Discord: Invite link

[leandrodamascena]

Assigning to @heitorlessa

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

[github-actions]

This is now released under 2.39.0 version!