Skip to content

Bug: Swagger generated UI has JSON format invalid URL #3793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ran-isenberg opened this issue Feb 18, 2024 · 4 comments · Fixed by #3796
Closed

Bug: Swagger generated UI has JSON format invalid URL #3793

ran-isenberg opened this issue Feb 18, 2024 · 4 comments · Fixed by #3796
Assignees
@rubenfonseca
Labels
bug Something isn't working

Comments

@ran-isenberg
Copy link
Contributor

Expected Behaviour

I deployed my API gateway to https://tzmt8vspl4.execute-api.us-east-1.amazonaws.com/prod/
It has the prod stage.
When i enter the /swagger URL, and click on the /swagger?format=json, i get the json file.

Current Behaviour

I get an invalid url and a permissions denied.
The generated URL there doesnt include the '/prod' part.

Code snippet

See https://github.com/ran-isenberg/aws-lambda-handler-cookbook/blob/main/cdk/service/api_construct.py the create swagger function.

Possible Solution

No response

Steps to Reproduce

Deploy the cookbook code.

Powertools for AWS Lambda (Python) version

latest

AWS Lambda function runtime

3.12

Packaging format used

PyPi

Debugging logs

No response
@ran-isenberg ran-isenberg added bug Something isn't working triage Pending triage from maintainers labels Feb 18, 2024
@rubenfonseca
Copy link
Contributor

Looking at this now

@rubenfonseca
Copy link
Contributor

Confirmed, working on a fix.

@rubenfonseca rubenfonseca moved this from Triage to Working on it in Powertools for AWS Lambda (Python) Feb 19, 2024
@rubenfonseca rubenfonseca removed the triage Pending triage from maintainers label Feb 19, 2024
@rubenfonseca rubenfonseca self-assigned this Feb 19, 2024
@rubenfonseca rubenfonseca mentioned this issue Feb 19, 2024
Merged
7 tasks
@rubenfonseca rubenfonseca linked a pull request Feb 19, 2024 that will close this issue
fix(event-handler): swagger schema respects api stage #3796
Merged
7 tasks
@github-project-automation github-project-automation bot moved this from Working on it to Coming soon in Powertools for AWS Lambda (Python) Feb 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@rubenfonseca rubenfonseca added the pending-release Fix or implementation already in dev waiting to be released label Feb 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

This is now released under 2.34.0 version!

@github-actions github-actions bot removed the pending-release Fix or implementation already in dev waiting to be released label Feb 21, 2024
@heitorlessa heitorlessa moved this from Coming soon to Shipped in Powertools for AWS Lambda (Python) Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rubenfonseca rubenfonseca

Labels
bug Something isn't working
Projects
Powertools for AWS Lambda (Python)
Status: Shipped
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(event-handler): swagger schema respects api stage aws-powertools/powertools-lambda-python
2 participants
@rubenfonseca @ran-isenberg