Feature request: Add addFilter and removeFilter to Logger

[rafrafek]

Use case

Pyright complains:

import logging
from aws_lambda_powertools.logging import Logger
logger = Logger(name="%(name)s")
temp_filter = logging.Filter()
logger.addFilter(temp_filter)  # Cannot access member "addFilter" for type "Logger"
logger.removeFilter(temp_filter)  # Cannot access member "removeFilter" for type "Logger"

Solution/User Experience

Add addFilter and removeFilter to Logger to match the built-in Python's logger.

Alternative solutions

import logging
from aws_lambda_powertools.logging import Logger
logger = Logger(name="%(name)s")
temp_filter = logging.Filter()
logger._logger.addFilter(temp_filter)
logger._logger.removeFilter(temp_filter)

Acknowledgment

• This feature request meets Powertools for AWS Lambda (Python) Tenets
• Should this be considered in other Powertools for AWS Lambda languages? i.e. Java, TypeScript, and .NET

[heitorlessa]

hey @rafrafek thanks a lot for reporting it, working on it now.

[heitorlessa]

Done - should be out in the next release after re:Invent. #3380

[rafrafek]

Thank you! Can you include removeFilter?

[heitorlessa]

Oops, forgot! Sending that shortly

[rafrafek]

Thanks!

[heitorlessa]

All done, merging shortly. Fixed the exception type too #3356

[heitorlessa]

Closing, coming up in the next release. Thank you one more time @rafrafek for reporting it!

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

[heitorlessa]

@rafrafek releasing it now so you don't have to wait until re:Invent is over :) A logger bugfix along with the release too

[github-actions]

This is now released under 2.27.1 version!

[rafrafek]

Thank you very much!