Skip to content

Docs: Twitch videos are broken in the "we-made-this" section #3095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
leandrodamascena opened this issue Sep 15, 2023 · 2 comments · Fixed by #3096
Closed
1 task done

Docs: Twitch videos are broken in the "we-made-this" section #3095

leandrodamascena opened this issue Sep 15, 2023 · 2 comments · Fixed by #3096
Assignees
@leandrodamascena
Labels
documentation Improvements or additions to documentation

Comments

@leandrodamascena
Copy link
Contributor

leandrodamascena commented Sep 15, 2023 •
edited
Loading

What were you searching in the docs?

After moving our website to a new domain, some Twitch videos are broken because they refer to the old domain

Example:

<iframe src="https://player.twitch.tv/?video=1034744364&parent=awslabs.github.io&autoplay=false" frameborder="0" allowfullscreen="true" scrolling="no" height="378" width="620"></iframe>

image

Is this related to an existing documentation section?

https://docs.powertools.aws.dev/lambda/python/latest/we_made_this/

How can we improve?

Fixing the domain reference.

Got a suggestion in mind?

No response

Acknowledgment

  • I understand the final update might be different from my proposed suggestion, or refused.
@leandrodamascena leandrodamascena added documentation Improvements or additions to documentation triage Pending triage from maintainers labels Sep 15, 2023
@leandrodamascena leandrodamascena mentioned this issue Sep 15, 2023
Merged
7 tasks
@leandrodamascena leandrodamascena linked a pull request Sep 15, 2023 that will close this issue
docs(we-made-this): fix broken Twitch video embeds #3096
Merged
7 tasks
@github-project-automation github-project-automation bot moved this from Triage to Coming soon in Powertools for AWS Lambda (Python) Sep 15, 2023
@github-actions
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added the pending-release Fix or implementation already in dev waiting to be released label Sep 15, 2023
@leandrodamascena leandrodamascena removed the triage Pending triage from maintainers label Sep 15, 2023
@leandrodamascena leandrodamascena self-assigned this Sep 15, 2023
@github-actions
Copy link
Contributor

This is now released under 2.25.0 version!

@github-actions github-actions bot removed the pending-release Fix or implementation already in dev waiting to be released label Sep 15, 2023
@heitorlessa heitorlessa moved this from Coming soon to Shipped in Powertools for AWS Lambda (Python) Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leandrodamascena leandrodamascena

Labels
documentation Improvements or additions to documentation
Projects
Powertools for AWS Lambda (Python)
Status: Shipped
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(we-made-this): fix broken Twitch video embeds
1 participant
@leandrodamascena