Skip to content

Tech debt: convert parser functional tests to unit test and modify the hardcoded values #2631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 of 2 tasks
leandrodamascena opened this issue Jul 3, 2023 · 2 comments · Fixed by #2656
Closed
1 of 2 tasks

Tech debt: convert parser functional tests to unit test and modify the hardcoded values #2631

leandrodamascena opened this issue Jul 3, 2023 · 2 comments · Fixed by #2656
Assignees
@leandrodamascena
Labels
parser Parser (Pydantic) utility tech-debt Technical Debt tasks

Comments

@leandrodamascena
Copy link
Contributor

Why is this needed?

We are about to create a RFC for Pydantic 2.0 and before that, we need to fix small things. This is a great opportunity to get this tech debt done.

Also, we need to refactor these tests to avoid hardcoded values to make them more flexible and maintainable.

Which area does this relate to?

Parser

Suggestion

No response

Acknowledgment
@leandrodamascena leandrodamascena added triage Pending triage from maintainers tech-debt Technical Debt tasks labels Jul 3, 2023
@leandrodamascena leandrodamascena self-assigned this Jul 3, 2023
@leandrodamascena leandrodamascena added parser Parser (Pydantic) utility and removed triage Pending triage from maintainers labels Jul 3, 2023
@leandrodamascena leandrodamascena mentioned this issue Jul 4, 2023
Merged
7 tasks
@github-actions github-actions bot added the pending-release Fix or implementation already in dev waiting to be released label Jul 5, 2023
@leandrodamascena leandrodamascena linked a pull request Jul 5, 2023 that will close this issue
refactor(parser): convert functional tests to unit tests #2656
Merged
7 tasks
@github-project-automation github-project-automation bot moved this from Triage to Coming soon in Powertools for AWS Lambda (Python) Jul 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@leandrodamascena leandrodamascena moved this from Coming soon to Shipped in Powertools for AWS Lambda (Python) Jul 5, 2023
@github-actions
Copy link
Contributor

This is now released under 2.20.0 version!

@github-actions github-actions bot removed the pending-release Fix or implementation already in dev waiting to be released label Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leandrodamascena leandrodamascena

Labels
parser Parser (Pydantic) utility tech-debt Technical Debt tasks
Projects
Powertools for AWS Lambda (Python)
Status: Shipped
Milestone
No milestone
1 participant
@leandrodamascena