Skip to content

Maintenance: Refactor Feature Flags #2060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 6 tasks
heitorlessa opened this issue Mar 28, 2023 · 2 comments
Closed
1 of 6 tasks

Maintenance: Refactor Feature Flags #2060

heitorlessa opened this issue Mar 28, 2023 · 2 comments
Labels
feature_flags Feature Flags utility rejected tech-debt Technical Debt tasks

Comments

@heitorlessa
Copy link
Contributor

Summary

Stream of consciousness tasks

  • Split feature flags functional tests into unit and functional
  • Make Schema Validation errors more granular (backwards compatible!) to decouple tests (match="...")
  • Review areas where we can make testing easier to author and less error-prone
  • Identify slowest areas that contribute to tests being the slowest in our test suites (e.g., we're unnecessarily creating a dict of anonymous lambda fns)

Why is this needed?

Feature flags tests are dubious in value and we tend to find newer bugs that are easily preventable - see #2058. We haven't invested much in refactoring feature flags since the early days, and rushed to launch for various reasons.

We need to pay tech debt and make it more robust, and more easily extensible (future bring-your-own-conditions of sorts, new Storage Layer).

Which area does this relate to?

Feature flags

Solution

No response

Acknowledgment

@heitorlessa heitorlessa added triage Pending triage from maintainers internal Maintenance changes feature_flags Feature Flags utility and removed triage Pending triage from maintainers labels Mar 28, 2023
@heitorlessa heitorlessa added tech-debt Technical Debt tasks and removed internal Maintenance changes labels Apr 17, 2023
ryanpudd added a commit to ryanpudd/powertools-lambda-python that referenced this issue Oct 18, 2023
@leandrodamascena leandrodamascena self-assigned this Oct 22, 2023
@leandrodamascena leandrodamascena moved this from Backlog to Pending review in Powertools for AWS Lambda (Python) Oct 22, 2023
@anafalcao
Copy link
Contributor

Closing as not planned for now

@anafalcao anafalcao closed this as not planned Won't fix, can't repro, duplicate, stale Jan 22, 2025
@github-project-automation github-project-automation bot moved this from Pending review to Coming soon in Powertools for AWS Lambda (Python) Jan 22, 2025
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@dreamorosi dreamorosi moved this from Coming soon to Shipped in Powertools for AWS Lambda (Python) Jan 22, 2025
@dreamorosi dreamorosi moved this from Shipped to Closed in Powertools for AWS Lambda (Python) Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature_flags Feature Flags utility rejected tech-debt Technical Debt tasks
Projects
4 participants