Skip to content

Maintenance: Replace Idempotency pytest fixtures with traceable test utilities #1972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 2 tasks
heitorlessa opened this issue Mar 1, 2023 · 2 comments
Closed
1 of 2 tasks
Labels
rejected tech-debt Technical Debt tasks

Comments

@heitorlessa
Copy link
Contributor

Summary

After regression #1968 due to the lack of tests, and the turnaround to create appropriate tests to confirm it, ascertain that it is time to get rid of pytest fixtures for any test that need more than one or so.

Why is this needed?

Idempotency is our most complex feature and it is too cumbersome to add new tests given the amount of fixtures and untraceable code within any IDE.

Which area does this relate to?

Idempotency

Solution

Completely and carefully overhaul tests/functional/idempotency to use utils.py for building Boto stubber expected input and response.

Acknowledgment

@heitorlessa heitorlessa added triage Pending triage from maintainers internal Maintenance changes labels Mar 1, 2023
@heitorlessa heitorlessa added help wanted Could use a second pair of eyes/hands and removed triage Pending triage from maintainers labels Mar 21, 2023
@heitorlessa heitorlessa added tech-debt Technical Debt tasks and removed internal Maintenance changes labels Apr 17, 2023
@sthulb sthulb moved this from Triage to Backlog in Powertools for AWS Lambda (Python) Jun 19, 2023
@anafalcao
Copy link
Contributor

Closing as not planned

@anafalcao anafalcao closed this as not planned Won't fix, can't repro, duplicate, stale Jan 22, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Coming soon in Powertools for AWS Lambda (Python) Jan 22, 2025
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@dreamorosi dreamorosi moved this from Coming soon to Closed in Powertools for AWS Lambda (Python) Jan 22, 2025
@dreamorosi dreamorosi added rejected and removed help wanted Could use a second pair of eyes/hands labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rejected tech-debt Technical Debt tasks
Projects
Development

No branches or pull requests

3 participants