Skip to content

Docs: Add IAM permissions in Idempotency #1901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
heitorlessa opened this issue Feb 6, 2023 · 5 comments
Closed
1 task done

Docs: Add IAM permissions in Idempotency #1901

heitorlessa opened this issue Feb 6, 2023 · 5 comments
Assignees
Labels
documentation Improvements or additions to documentation idempotency Idempotency utility

Comments

@heitorlessa
Copy link
Contributor

What were you searching in the docs?

As described by @mattyweb in #1772 (comment):


Just found this thread and upgraded to the new PowerTools in order to troubleshoot. Trying an idempotent lambda in python and this was my first time using DynamoDB.

Had to add the following actions to my lambda config:
"Action": [
"dynamodb:GetItem",
"dynamodb:PutItem",
"dynamodb:UpdateItem",
"dynamodb:DeleteItem"
],

Don't know how I would have figured this out otherwise. Might be good to add this to the PowerTools Idempotency docs! (Unless I just missed it!)


Is this related to an existing documentation section?

https://awslabs.github.io/aws-lambda-powertools-python/2.7.1/utilities/idempotency/

How can we improve?

Add a dedicated section to IAM similar to other places like Parameters: https://awslabs.github.io/aws-lambda-powertools-python/2.7.1/utilities/parameters/#iam-permissions

Got a suggestion in mind?

No response

Acknowledgment

  • I understand the final update might be different from my proposed suggestion, or refused.
@heitorlessa heitorlessa added documentation Improvements or additions to documentation triage Pending triage from maintainers idempotency Idempotency utility and removed triage Pending triage from maintainers labels Feb 6, 2023
@leandrodamascena
Copy link
Contributor

How can we improve?

Add a dedicated section to IAM similar to other places like Parameters: awslabs.github.io/aws-lambda-powertools-python/2.7.1/utilities/parameters/#iam-permissions

This is a good example, but I don't think we need to create a table for this, because we only have one resource: DynamoDB. We could do what we did here https://awslabs.github.io/aws-lambda-powertools-python/2.7.1/utilities/feature_flags/#iam-permissions.

Could be something like this:
image

@heitorlessa
Copy link
Contributor Author

Agree. We can expand when #1181 completes or when we add additional providers. Let's wait by EOD (Central European Time - CET) to hear whether @mattyweb would like to make his first contribution with our help, OR decide to go ahead with the change and credit Matt for spotting it (crediting should happen either way).

@github-actions github-actions bot added the pending-release Fix or implementation already in dev waiting to be released label Feb 6, 2023
@heitorlessa
Copy link
Contributor Author

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions
Copy link
Contributor

This is now released under 2.8.0 version!

@github-actions github-actions bot removed the pending-release Fix or implementation already in dev waiting to be released label Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation idempotency Idempotency utility
Projects
None yet
Development

No branches or pull requests

2 participants