Skip to content

Example links in README result in 404s #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
skwashd opened this issue Sep 30, 2020 · 2 comments
Closed

Example links in README result in 404s #184

skwashd opened this issue Sep 30, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@skwashd
Copy link

skwashd commented Sep 30, 2020

What were you trying to accomplish?

Review the example project

Expected Behavior

When I click the example links I should see the example project

Current Behavior

Clicking the link results in a 404

Possible Solution

This was introduced by #180. Either reinstate the example project or remove the reference to it in the docs.

Steps to Reproduce (for bugs)

  1. Navigate to https://github.com/awslabs/aws-lambda-powertools-python
  2. Click the kitchen sink example link
  3. See a 404 page
  4. Wonder if you've done something wrong
  5. Swear
  6. Click the browser's back button
  7. Find the example link further down the page
  8. Click the link
  9. Get another 404
  10. Click back
  11. Swear

Environment

  • Powertools version used: develop @ d08de0b
  • Packaging format (Layers, PyPi): GitHub web UI
  • AWS Lambda function runtime: N/A
  • Debugging logs N/A

Screen Shot 2020-09-30 at 11 36 05 am

@skwashd skwashd added bug Something isn't working triage Pending triage from maintainers labels Sep 30, 2020
@heitorlessa
Copy link
Contributor

Hi @skwashd - Thanks for spotting this.

I've recently removed to unblock another PR and accidentally didn't update the README links - Use this below instead

https://github.com/aws-samples/cookiecutter-aws-sam-python

If using SAM CLI, you can instantiate using: sam init --location https://github.com/aws-samples/cookiecutter-aws-sam-python

And these are more concrete examples:

https://github.com/aws-samples/aws-serverless-shopping-cart

https://github.com/aws-samples/aws-serverless-ecommerce-platform

https://github.com/aws-samples/aws-serverless-airline-booking

@skwashd
Copy link
Author

skwashd commented Sep 30, 2020

Thanks for the links.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

3 participants