Skip to content

Maintenance: Missing test for function url authZ #1416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 2 tasks
heitorlessa opened this issue Aug 5, 2022 · 1 comment
Closed
1 of 2 tasks

Maintenance: Missing test for function url authZ #1416

heitorlessa opened this issue Aug 5, 2022 · 1 comment
Assignees
Labels
tech-debt Technical Debt tasks

Comments

@heitorlessa
Copy link
Contributor

Summary

Function URL latest introduction is missing a test without authorization fields. This will ensure code paths work when a function URL is configured as NONE for AuthType.

Test: https://github.com/awslabs/aws-lambda-powertools-python/blob/develop/tests/functional/data_classes/test_lambda_function_url.py#L5

Why is this needed?

Completeness. Functional tests are covering only when IAM is set and not when NONE is set, this will help verify future AuthZ options added to Function URL, and uncover any side effect when these aren't available.

Which area does this relate to?

Event Handler - REST API

Solution

Rename test_lambda_function_url_event to test_lambda_function_url_event_iam, and create a new test test_lambda_function_url_event to cover NONE and all potential authZ keys that might not exist in Function URL

Acknowledgment

@heitorlessa heitorlessa added triage Pending triage from maintainers internal Maintenance changes labels Aug 5, 2022
@heitorlessa heitorlessa removed the triage Pending triage from maintainers label Aug 5, 2022
@github-actions github-actions bot added the pending-release Fix or implementation already in dev waiting to be released label Aug 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2022

This is now released under 1.27.0 version!

@github-actions github-actions bot closed this as completed Aug 5, 2022
@github-actions github-actions bot removed the pending-release Fix or implementation already in dev waiting to be released label Aug 5, 2022
@heitorlessa heitorlessa added tech-debt Technical Debt tasks and removed internal Maintenance changes labels Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt Technical Debt tasks
Projects
None yet
Development

No branches or pull requests

2 participants