Skip to content

Expose version function in package root #1382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
heitorlessa opened this issue Jul 25, 2022 · 2 comments · Fixed by #2267
Closed

Expose version function in package root #1382

heitorlessa opened this issue Jul 25, 2022 · 2 comments · Fixed by #2267
Assignees
@leandrodamascena
Labels
tech-debt Technical Debt tasks

Comments

@heitorlessa
Copy link
Contributor

heitorlessa commented Jul 25, 2022 •
edited
Loading

With Python 3.6 being dropped in v2, we can use use importlib to expose a version function.

Since importlib looks up DIST files to gather package information, it'll impact cold start performance. Instead, we should create a version and use lazy import to amortize the overhead.

NOTE: importlib.metadata is only available in 3.8. Reducing priority and assigning a help wanted.
@heitorlessa heitorlessa mentioned this issue Jul 25, 2022
Closed
9 tasks
@heitorlessa heitorlessa added internal Maintenance changes documentation Improvements or additions to documentation labels Jul 25, 2022
@heitorlessa heitorlessa self-assigned this Sep 20, 2022
@heitorlessa heitorlessa added v2 and removed v2 labels Sep 20, 2022
@heitorlessa heitorlessa changed the title Python 3.6 deprecation: Revisit use of importlib to display version as a package variable Expose __version__ attribute Oct 18, 2022
@heitorlessa heitorlessa removed the documentation Improvements or additions to documentation label Oct 18, 2022
@heitorlessa heitorlessa changed the title Expose __version__ attribute Expose version function in package root Oct 18, 2022
@heitorlessa heitorlessa added the help wanted Could use a second pair of eyes/hands label Oct 18, 2022
@heitorlessa heitorlessa removed their assignment Nov 18, 2022
@heitorlessa heitorlessa added tech-debt Technical Debt tasks and removed internal Maintenance changes labels Apr 17, 2023
@leandrodamascena leandrodamascena self-assigned this May 18, 2023
@leandrodamascena leandrodamascena linked a pull request May 19, 2023 that will close this issue
feat(user-agent): add custom header User-Agent to AWS SDK requests #2267
Merged
7 tasks
@leandrodamascena
Copy link
Contributor

Hi @heitorlessa! I include this in User Agent PR.

@leandrodamascena leandrodamascena removed the help wanted Could use a second pair of eyes/hands label May 19, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leandrodamascena leandrodamascena

Labels
tech-debt Technical Debt tasks
Projects
None yet
Milestone
No milestone
2 participants
@heitorlessa @leandrodamascena