Skip to content

Maintenance: Lint GitHub Actions workflow #1332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
heitorlessa opened this issue Jul 21, 2022 · 3 comments
Closed
2 tasks done

Maintenance: Lint GitHub Actions workflow #1332

heitorlessa opened this issue Jul 21, 2022 · 3 comments
Labels
tech-debt Technical Debt tasks

Comments

@heitorlessa
Copy link
Contributor

Summary

GitHub provides linting for Actions in the editor console only. We could automate linting as a pre-commit hook and/or an action to validate workflows: https://github.com/rhysd/actionlint

In the first attempt there were some false positives due to shellcheck integration but may be easy to disable as we move most of our logic to Github-script.

Why is this needed?

We've had several issues with GitHub Actions in the past week due to bad syntax or using an unsupported syntax in blocks of a workflow - this could've caught early.

Which area does this relate to?

Automation

Solution

No response

Acknowledgment

@heitorlessa heitorlessa added triage Pending triage from maintainers internal Maintenance changes labels Jul 21, 2022
@heitorlessa heitorlessa removed the triage Pending triage from maintainers label Aug 8, 2022
@heitorlessa heitorlessa self-assigned this Aug 25, 2022
@heitorlessa heitorlessa linked a pull request Aug 25, 2022 that will close this issue
7 tasks
@github-actions github-actions bot added the pending-release Fix or implementation already in dev waiting to be released label Aug 25, 2022
@heitorlessa heitorlessa removed their assignment Aug 29, 2022
@heitorlessa
Copy link
Contributor Author

fully working now

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2022

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions
Copy link
Contributor

This is now released under 1.29.0 version!

@github-actions github-actions bot removed the pending-release Fix or implementation already in dev waiting to be released label Sep 13, 2022
@heitorlessa heitorlessa added tech-debt Technical Debt tasks and removed internal Maintenance changes labels Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt Technical Debt tasks
Projects
None yet
Development

No branches or pull requests

1 participant