Skip to content

Bug: regression in pip release that included mypy-boto3-* dev dependencies #1321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 2 tasks
tb102122 opened this issue Jul 20, 2022 · 6 comments
Closed
1 of 2 tasks
Labels
bug Something isn't working

Comments

@tb102122
Copy link

Is this related to an existing feature request or issue?

No response

Which AWS Lambda Powertools utility does this relate to?

Other

Summary

Why do we need the dependency in the final release build?

mypy-boto3-cloudwatch = "^1.24.0"
mypy-boto3-lambda = "^1.24.0"
mypy-boto3-xray = "^1.24.0"

Use case

reduce package size

Proposal

remove dependency

Out of scope

n/a

Potential challenges

n/a

Dependencies and Integrations

No response

Alternative solutions

No response

Acknowledgment

@tb102122 tb102122 added RFC triage Pending triage from maintainers labels Jul 20, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 20, 2022

Thanks for opening your first issue here! We'll come back to you as soon as we can.

@heitorlessa heitorlessa added bug Something isn't working and removed RFC triage Pending triage from maintainers labels Jul 20, 2022
@heitorlessa
Copy link
Contributor

hey @tb102122 that's a bug, this should have been a dev dependency like other mypy types we have; an oversight from our part when merging @mploski E2E testing PR: https://github.com/awslabs/aws-lambda-powertools-python/blame/develop/pyproject.toml#L29

We'll make a patch release in the next 2 hours to address it

@tb102122
Copy link
Author

Great thanks!

@github-actions
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added the pending-release Fix or implementation already in dev waiting to be released label Jul 20, 2022
@heitorlessa heitorlessa changed the title RFC: dependnacy needed in pip release Bug: dependnacy needed in pip release Jul 20, 2022
@heitorlessa heitorlessa changed the title Bug: dependnacy needed in pip release Bug: regression in pip release that included mypy-boto3-* dev dependencies Jul 20, 2022
@github-actions
Copy link
Contributor

This is now released under 1.26.5 version!

@github-actions github-actions bot removed the pending-release Fix or implementation already in dev waiting to be released label Jul 20, 2022
@heitorlessa
Copy link
Contributor

@tb102122 now live on PyPi and SAR (v1.26.5) -- Lambda Layer might take a few hours to update across regions.

Huge thanks again @tb102122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants