Skip to content

Commit f93fd77

Browse files
committed
chore: mypy
1 parent 284c4e8 commit f93fd77

File tree

1 file changed

+11
-10
lines changed

1 file changed

+11
-10
lines changed

aws_lambda_powertools/logging/logger.py

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
Optional,
2020
TypeVar,
2121
Union,
22+
cast,
2223
overload,
2324
)
2425

@@ -284,14 +285,14 @@ def _get_logger(self) -> logging.Logger:
284285

285286
return logging.getLogger(logger_name)
286287

287-
def _get_handler(self) -> logging.Handler | None:
288+
def _get_handler(self) -> logging.Handler:
288289
# is a logger handler already configured?
289290
if getattr(self, LOGGER_ATTRIBUTE_HANDLER, None):
290291
return self.logger_handler
291292

292293
# for children, use parent's handler
293294
if self.child:
294-
return getattr(self._logger.parent, LOGGER_ATTRIBUTE_POWERTOOLS_HANDLER, None)
295+
return getattr(self._logger.parent, LOGGER_ATTRIBUTE_POWERTOOLS_HANDLER, None) # type: ignore[return-value] # always checked in formatting
295296

296297
# otherwise, create a new stream handler (first time init)
297298
return logging.StreamHandler(self._stream)
@@ -695,15 +696,15 @@ def registered_handler(self) -> logging.Handler:
695696
@property
696697
def registered_formatter(self) -> BasePowertoolsFormatter:
697698
"""Convenience property to access the first logger formatter"""
698-
if self.child:
699-
if self._get_handler() is None:
700-
raise OrphanedChildLoggerError(
701-
"Orphan child loggers cannot append nor remove keys until a parent is initialized first. "
702-
"To solve this issue, you can A) make sure a parent logger is initialized first, or B) move append/remove keys operations to a later stage." # noqa: E501
703-
"Reference: https://docs.powertools.aws.dev/lambda/python/latest/core/logger/#reusing-logger-across-your-code",
704-
)
699+
handler = self.registered_handler
700+
if handler is None:
701+
raise OrphanedChildLoggerError(
702+
"Orphan child loggers cannot append nor remove keys until a parent is initialized first. "
703+
"To solve this issue, you can A) make sure a parent logger is initialized first, or B) move append/remove keys operations to a later stage." # noqa: E501
704+
"Reference: https://docs.powertools.aws.dev/lambda/python/latest/core/logger/#reusing-logger-across-your-code",
705+
)
705706

706-
return self.registered_handler.formatter
707+
return cast(BasePowertoolsFormatter, handler.formatter)
707708

708709
@property
709710
def log_level(self) -> int:

0 commit comments

Comments
 (0)