Skip to content

Commit f190a13

Browse files
committed
chore: review findings
1 parent 37d6468 commit f190a13

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

aws_lambda_powertools/utilities/data_classes/kafka_event.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -74,15 +74,15 @@ def get_header_value(
7474
self,
7575
name: str,
7676
default_value: str,
77-
case_sensitive: bool = False,
77+
case_sensitive: bool = True,
7878
) -> str: ...
7979

8080
@overload
8181
def get_header_value(
8282
self,
8383
name: str,
8484
default_value: Optional[str] = None,
85-
case_sensitive: bool = False,
85+
case_sensitive: bool = True,
8686
) -> Optional[str]: ...
8787

8888
def get_header_value(

aws_lambda_powertools/utilities/data_classes/shared_functions.py

+11-11
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
from __future__ import annotations
22

33
import base64
4-
from typing import Any, overload
4+
from typing import Any, Dict, overload
55

66

77
def base64_decode(value: str) -> str:
@@ -26,7 +26,7 @@ def get_header_value(
2626
headers: dict[str, Any],
2727
name: str,
2828
default_value: str,
29-
case_sensitive: bool | None = None,
29+
case_sensitive: bool | None = False,
3030
) -> str: ...
3131

3232

@@ -35,29 +35,29 @@ def get_header_value(
3535
headers: dict[str, Any],
3636
name: str,
3737
default_value: str | None = None,
38-
case_sensitive: bool | None = None,
38+
case_sensitive: bool | None = False,
3939
) -> str | None: ...
4040

4141

4242
def get_header_value(
4343
headers: dict[str, Any],
4444
name: str,
4545
default_value: str | None = None,
46-
case_sensitive: bool | None = None,
46+
case_sensitive: bool | None = False,
4747
) -> str | None:
4848
"""
4949
Get the value of a header by its name.
5050
5151
Parameters
5252
----------
53-
headers: dict[str, str]
53+
headers: Dict[str, str]
5454
The dictionary of headers.
5555
name: str
5656
The name of the header to retrieve.
5757
default_value: str, optional
5858
The default value to return if the header is not found. Default is None.
5959
case_sensitive: bool, optional
60-
Indicates whether the header name should be case-sensitive. Default is None.
60+
Indicates whether the header name should be case-sensitive. Default is False.
6161
6262
Returns
6363
-------
@@ -82,22 +82,22 @@ def get_header_value(
8282

8383
@overload
8484
def get_query_string_value(
85-
query_string_parameters: dict[str, str] | None,
85+
query_string_parameters: Dict[str, str] | None,
8686
name: str,
8787
default_value: str,
8888
) -> str: ...
8989

9090

9191
@overload
9292
def get_query_string_value(
93-
query_string_parameters: dict[str, str] | None,
93+
query_string_parameters: Dict[str, str] | None,
9494
name: str,
9595
default_value: str | None = None,
9696
) -> str | None: ...
9797

9898

9999
def get_query_string_value(
100-
query_string_parameters: dict[str, str] | None,
100+
query_string_parameters: Dict[str, str] | None,
101101
name: str,
102102
default_value: str | None = None,
103103
) -> str | None:
@@ -121,7 +121,7 @@ def get_query_string_value(
121121

122122

123123
def get_multi_value_query_string_values(
124-
multi_value_query_string_parameters: dict[str, list[str]] | None,
124+
multi_value_query_string_parameters: Dict[str, list[str]] | None,
125125
name: str,
126126
default_values: list[str] | None = None,
127127
) -> list[str]:
@@ -137,7 +137,7 @@ def get_multi_value_query_string_values(
137137
138138
Returns
139139
-------
140-
list[str]. optional
140+
List[str]. optional
141141
The values of the query string parameter if found, or the default values if not found.
142142
"""
143143

0 commit comments

Comments
 (0)