Skip to content

Commit e9d627b

Browse files
committed
chore: assert handlers; assert defaults create and use PT handler
1 parent 3602a80 commit e9d627b

File tree

1 file changed

+13
-0
lines changed

1 file changed

+13
-0
lines changed

tests/functional/test_logger.py

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1193,6 +1193,7 @@ class ForeignHandler(logging.StreamHandler): ...
11931193
assert logger.registered_handler is not foreign_handler
11941194
assert logger.registered_handler is custom_handler
11951195
assert logger.logger_handler is custom_handler
1196+
assert logger.handlers == [foreign_handler, custom_handler]
11961197

11971198

11981199
def test_child_logger_registered_handler_is_custom_handler(service_name):
@@ -1215,6 +1216,18 @@ class ForeignHandler(logging.StreamHandler): ...
12151216
assert child.registered_handler is parent.registered_handler
12161217

12171218

1219+
def test_logger_handler_is_created_despite_env_pre_setup(service_name):
1220+
# GIVEN a library or environment pre-setup a logger for us using the same name
1221+
environment_handler = logging.StreamHandler()
1222+
logging.getLogger(service_name).addHandler(environment_handler)
1223+
1224+
# WHEN Logger init without a custom handler
1225+
logger = Logger(service=service_name)
1226+
1227+
# THEN registered handler should be Powertools default handler, not env
1228+
assert logger.registered_handler is not environment_handler
1229+
1230+
12181231
def test_child_logger_append_keys_before_parent(stdout, service_name):
12191232
# GIVEN a child Logger is initialized before its/without parent
12201233
child = Logger(stream=stdout, service=service_name, child=True)

0 commit comments

Comments
 (0)