chore: var names cleanup

Author: heitorlessa

tests/e2e/utils/infrastructure.py

@@ -67,7 +67,7 @@ def create_lambda_functions(self, function_props: Optional[Dict] = None):
         Parameters
         ----------
         function_props: Optional[Dict]
-            CDK Lambda FunctionProps as dictionary to override defaults
+            Dictionary representing CDK Lambda FunctionProps to override defaults
 
         Examples
         --------
@@ -88,16 +88,14 @@ def create_lambda_functions(self, function_props: Optional[Dict] = None):
         """
         handlers = list(self.handlers_dir.rglob("*.py"))
         source = Code.from_asset(f"{self.handlers_dir}")
-        props_override = function_props or {}
         logger.debug(f"Creating functions for handlers: {handlers}")
         if not self.layer_arn:
             raise ValueError(
                 """Lambda Layer ARN cannot be empty when creating Lambda functions.
                 Make sure to inject `lambda_layer_arn` fixture and pass at the constructor level"""
             )
 
-        layer = LayerVersion.from_layer_version_arn(self.stack, "layer-arn", layer_version_arn=self.layer_arn)
-
+        function_settings_override = function_props or {}
         for fn in handlers:
             fn_name = fn.stem
             fn_name_pascal_case = fn_name.title().replace("_", "")  # basic_handler -> BasicHandler
@@ -108,24 +106,24 @@ def create_lambda_functions(self, function_props: Optional[Dict] = None):
                 "handler": f"{fn_name}.lambda_handler",
                 "tracing": Tracing.ACTIVE,
                 "runtime": Runtime.PYTHON_3_9,
-                "layers": [layer],
-                **props_override,
+                "layers": [
+                    LayerVersion.from_layer_version_arn(self.stack, "layer-arn", layer_version_arn=self.layer_arn)
+                ],
+                **function_settings_override,
             }
 
-            function_python = Function(self.stack, **function_settings)
+            function = Function(self.stack, **function_settings)
 
             aws_logs.LogGroup(
                 self.stack,
                 id=f"{fn_name}-lg",
-                log_group_name=f"/aws/lambda/{function_python.function_name}",
+                log_group_name=f"/aws/lambda/{function.function_name}",
                 retention=aws_logs.RetentionDays.ONE_DAY,
                 removal_policy=RemovalPolicy.DESTROY,
             )
 
             # CFN Outputs only support hyphen hence pascal case
-            self.add_cfn_output(
-                name=fn_name_pascal_case, value=function_python.function_name, arn=function_python.function_arn
-            )
+            self.add_cfn_output(name=fn_name_pascal_case, value=function.function_name, arn=function.function_arn)
 
     def deploy(self) -> Dict[str, str]:
         """Creates CloudFormation Stack and return stack outputs as dict