Skip to content

Commit b6b130d

Browse files
authored
fix(typing): level arg in copy_config_to_registered_loggers (#1534)
1 parent 93a022c commit b6b130d

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

Diff for: aws_lambda_powertools/logging/utils.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
def copy_config_to_registered_loggers(
1010
source_logger: Logger,
11-
log_level: Optional[str] = None,
11+
log_level: Optional[Union[int, str]] = None,
1212
exclude: Optional[Set[str]] = None,
1313
include: Optional[Set[str]] = None,
1414
) -> None:
@@ -19,7 +19,7 @@ def copy_config_to_registered_loggers(
1919
----------
2020
source_logger : Logger
2121
Powertools Logger to copy configuration from
22-
log_level : str, optional
22+
log_level : Union[int, str], optional
2323
Logging level to set to registered loggers, by default uses source_logger logging level
2424
include : Optional[Set[str]], optional
2525
List of logger names to include, by default all registered loggers are included

Diff for: tests/functional/test_logger_utils.py

+5-3
Original file line numberDiff line numberDiff line change
@@ -161,15 +161,17 @@ def test_copy_config_to_ext_loggers_clean_old_handlers(stdout, logger, log_level
161161
assert isinstance(logger.handlers[0].formatter, formatter.LambdaPowertoolsFormatter)
162162

163163

164-
def test_copy_config_to_ext_loggers_custom_log_level(stdout, logger, log_level):
164+
@pytest.mark.parametrize("level_to_set", ["WARNING", 30])
165+
def test_copy_config_to_ext_loggers_custom_log_level(stdout, logger, log_level, level_to_set):
165166
# GIVEN an external logger and powertools logger initialized
166167
logger = logger()
167168
powertools_logger = Logger(service=service_name(), level=log_level.CRITICAL.value, stream=stdout)
168-
level = log_level.WARNING.name
169169

170170
# WHEN configuration copied from powertools logger to INCLUDED external logger
171171
# AND external logger used with custom log_level
172-
utils.copy_config_to_registered_loggers(source_logger=powertools_logger, include={logger.name}, log_level=level)
172+
utils.copy_config_to_registered_loggers(
173+
source_logger=powertools_logger, include={logger.name}, log_level=level_to_set
174+
)
173175
msg = "test message4"
174176
logger.warning(msg)
175177
log = capture_logging_output(stdout)

0 commit comments

Comments
 (0)