Skip to content

Commit b3c9ee0

Browse files
fix(event_source): kinesis subsequenceNumber str type to int (#3275)
Co-authored-by: Leandro Damascena <[email protected]>
1 parent 114da01 commit b3c9ee0

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

aws_lambda_powertools/utilities/data_classes/kinesis_firehose_event.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ def sequence_number(self) -> str:
201201
return self._metadata["sequenceNumber"]
202202

203203
@property
204-
def subsequence_number(self) -> str:
204+
def subsequence_number(self) -> int:
205205
"""Kinesis stream sub-sequence number; present only when Kinesis Stream is source
206206
207207
Note: this will only be present for Kinesis streams using record aggregation

aws_lambda_powertools/utilities/parser/models/kinesis_firehose.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ class KinesisFirehoseRecordMetadata(BaseModel):
1010
partitionKey: str
1111
approximateArrivalTimestamp: PositiveInt
1212
sequenceNumber: str
13-
subsequenceNumber: str
13+
subsequenceNumber: int
1414

1515

1616
class KinesisFirehoseRecord(BaseModel):

tests/events/kinesisFirehoseKinesisEvent.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"partitionKey": "4d1ad2b9-24f8-4b9d-a088-76e9947c317a",
1414
"approximateArrivalTimestamp": 1664028820148,
1515
"sequenceNumber": "49546986683135544286507457936321625675700192471156785154",
16-
"subsequenceNumber": ""
16+
"subsequenceNumber": 0
1717
}
1818
},
1919
{
@@ -25,7 +25,7 @@
2525
"partitionKey": "4d1ad2b9-24f8-4b9d-a088-76e9947c318a",
2626
"approximateArrivalTimestamp": 1664028793294,
2727
"sequenceNumber": "49546986683135544286507457936321625675700192471156785155",
28-
"subsequenceNumber": ""
28+
"subsequenceNumber": 0
2929
}
3030
}
3131
]

tests/unit/parser/test_kinesis_firehose.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ def test_firehose_trigger_event_kinesis_no_envelope():
6262

6363
metadata_01: KinesisFirehoseRecordMetadata = record_01.kinesisRecordMetadata
6464
assert metadata_01.partitionKey == "4d1ad2b9-24f8-4b9d-a088-76e9947c317a"
65-
assert metadata_01.subsequenceNumber == ""
65+
assert metadata_01.subsequenceNumber == 0
6666
assert metadata_01.shardId == "shardId-000000000000"
6767
assert metadata_01.approximateArrivalTimestamp == 1664028820148
6868
assert metadata_01.sequenceNumber == "49546986683135544286507457936321625675700192471156785154"
@@ -74,7 +74,7 @@ def test_firehose_trigger_event_kinesis_no_envelope():
7474

7575
metadata_02: KinesisFirehoseRecordMetadata = record_02.kinesisRecordMetadata
7676
assert metadata_02.partitionKey == "4d1ad2b9-24f8-4b9d-a088-76e9947c318a"
77-
assert metadata_02.subsequenceNumber == ""
77+
assert metadata_02.subsequenceNumber == 0
7878
assert metadata_02.shardId == "shardId-000000000001"
7979
assert metadata_02.approximateArrivalTimestamp == 1664028793294
8080
assert metadata_02.sequenceNumber == "49546986683135544286507457936321625675700192471156785155"

0 commit comments

Comments
 (0)