chore(tests): add end-to-end test

Author: heitorlessa

Diff for: aws_lambda_powertools/utilities/parameters/ssm.py

@@ -403,7 +403,7 @@ def get_parameters_by_name(
     decrypt: bool = False,
     force_fetch: bool = False,
     max_age: int = DEFAULT_MAX_AGE_SECS,
-    parallel: bool = True,
+    parallel: bool = False,
 ) -> Union[Dict[str, str], Dict[str, bytes], Dict[str, dict]]:
     """
     Retrieve multiple parameter values by name from AWS Systems Manager (SSM) Parameter Store
@@ -432,10 +432,8 @@ def get_parameters_by_name(
         When the parameter provider fails to transform a parameter value.
     """
 
-    # NOTE: Need a param for hard failure mode on parameter retrieval
-    # by default, we should return an empty string on failure (ask customer for desired behaviour)
-
-    # NOTE: Decide whether to leave multi-threaded option or not due to slower results (throttling+fork cost)
+    # NOTE: Need a param for hard failure mode on parameter retrieval (asked feature request author)
+    # NOTE: Decide whether to leave multi-threaded option or not due to slower results (throttling+LWP cost)
 
     ret: Dict[str, Any] = {}
     future_to_param: Dict[Future, str] = {}

Diff for: tests/e2e/parameters/handlers/parameter_ssm_get_parameters_by_name.py

@@ -0,0 +1,15 @@
+import json
+import os
+from typing import Any, Dict, List, cast
+
+from aws_lambda_powertools.utilities.parameters.ssm import get_parameters_by_name
+from aws_lambda_powertools.utilities.typing import LambdaContext
+
+parameters_list: List[str] = cast(List, json.loads(os.getenv("parameters", "")))
+
+
+def lambda_handler(event: dict, context: LambdaContext) -> Dict[str, Any]:
+    parameters_to_fetch: Dict[str, Any] = {param: {} for param in parameters_list}
+
+    # response`{parameter:value}`
+    return get_parameters_by_name(parameters=parameters_to_fetch, max_age=0, parallel=True)

Diff for: tests/e2e/parameters/infrastructure.py

@@ -1,18 +1,38 @@
-from pyclbr import Function
+import json
+from typing import List
 
-from aws_cdk import CfnOutput
+from aws_cdk import CfnOutput, Duration
 from aws_cdk import aws_appconfig as appconfig
 from aws_cdk import aws_iam as iam
+from aws_cdk import aws_ssm as ssm
+from aws_cdk.aws_lambda import Function
 
-from tests.e2e.utils.data_builder import build_service_name
+from tests.e2e.utils.data_builder import build_random_value, build_service_name
 from tests.e2e.utils.infrastructure import BaseInfrastructure
 
 
 class ParametersStack(BaseInfrastructure):
     def create_resources(self):
-        functions = self.create_lambda_functions()
+        parameters = self._create_ssm_parameters()
+
+        env_vars = {"parameters": json.dumps(parameters)}
+        functions = self.create_lambda_functions(
+            function_props={"environment": env_vars, "timeout": Duration.seconds(30)}
+        )
+
         self._create_app_config(function=functions["ParameterAppconfigFreeformHandler"])
 
+        # NOTE: Enforce least-privilege for our param tests only
+        functions["ParameterSsmGetParametersByName"].add_to_role_policy(
+            iam.PolicyStatement(
+                effect=iam.Effect.ALLOW,
+                actions=[
+                    "ssm:GetParameter",
+                ],
+                resources=[f"arn:aws:ssm:{self.region}:{self.account_id}:parameter/powertools/e2e/parameters/*"],
+            )
+        )
+
     def _create_app_config(self, function: Function):
 
         service_name = build_service_name()
@@ -106,3 +126,16 @@ def _create_app_config_freeform(
                 resources=["*"],
             )
         )
+
+    def _create_ssm_parameters(self) -> List[str]:
+        parameters: List[str] = []
+
+        for _ in range(10):
+            param = f"/powertools/e2e/parameters/{build_random_value()}"
+            rand = build_random_value()
+            ssm.StringParameter(self.stack, f"param-{rand}", parameter_name=param, string_value=rand)
+            parameters.append(param)
+
+        CfnOutput(self.stack, "ParametersNameList", value=json.dumps(parameters))
+
+        return parameters

Diff for: tests/e2e/parameters/test_ssm.py

@@ -0,0 +1,33 @@
+import json
+from typing import Any, Dict, List
+
+import pytest
+
+from tests.e2e.utils import data_fetcher
+
+
+@pytest.fixture
+def ssm_get_parameters_by_name_fn_arn(infrastructure: dict) -> str:
+    return infrastructure.get("ParameterSsmGetParametersByNameArn", "")
+
+
+@pytest.fixture
+def parameters_list(infrastructure: dict) -> List[str]:
+    param_list = infrastructure.get("ParametersNameList", "[]")
+    return json.loads(param_list)
+
+
+def test_get_parameter_appconfig_freeform(
+    ssm_get_parameters_by_name_fn_arn: str,
+    parameters_list: str,
+):
+    # GIVEN/WHEN
+    function_response, _ = data_fetcher.get_lambda_response(lambda_arn=ssm_get_parameters_by_name_fn_arn)
+    parameter_values: Dict[str, Any] = json.loads(function_response["Payload"].read().decode("utf-8"))
+
+    # THEN
+    for param in parameters_list:
+        try:
+            assert parameter_values[param] is not None
+        except (KeyError, TypeError):
+            pytest.fail(f"Parameter {param} not found in response")