fix: improve coverage

Author: rubenfonseca

aws_lambda_powertools/event_handler/middlewares/openapi_validation.py

@@ -110,12 +110,10 @@ def handler(self, app: EventHandlerInstance, next_middleware: NextMiddleware) ->
     def _handle_response(self, *, route: Route, response: Response):
         # Process the response body if it exists
         if response.body:
-            raw_response = jsonable_encoder(response.body)
-
             # Validate and serialize the response, if it's JSON
             if response.is_json():
                 response.body = json.dumps(
-                    self._serialize_response(field=route.dependant.return_param, response_content=raw_response),
+                    self._serialize_response(field=route.dependant.return_param, response_content=response.body),
                     sort_keys=True,
                 )
 

tests/functional/event_handler/test_openapi_validation_middleware.py

@@ -2,7 +2,7 @@
 from dataclasses import dataclass
 from enum import Enum
 from pathlib import PurePath
-from typing import Tuple
+from typing import List, Tuple
 
 import pytest
 from pydantic import BaseModel
@@ -113,6 +113,24 @@ def handler() -> int:
     assert result["body"] == "123"
 
 
+def test_validate_return_list():
+    # GIVEN an APIGatewayRestResolver with validation enabled
+    app = APIGatewayRestResolver(enable_validation=True)
+
+    # WHEN a handler is defined with a return type
+    @app.get("/")
+    def handler() -> List[int]:
+        return [123, 234]
+
+    LOAD_GW_EVENT["path"] = "/"
+
+    # THEN the handler should be invoked and return 200
+    # THEN the body must be [123, 234]
+    result = app(LOAD_GW_EVENT, {})
+    assert result["statusCode"] == 200
+    assert result["body"] == "[123, 234]"
+
+
 def test_validate_return_tuple():
     # GIVEN an APIGatewayRestResolver with validation enabled
     app = APIGatewayRestResolver(enable_validation=True)
@@ -143,7 +161,7 @@ def test_validate_return_purepath():
     # WHEN return value is a PurePath
     @app.get("/")
     def handler() -> str:
-        return sample_path
+        return sample_path.as_posix()
 
     LOAD_GW_EVENT["path"] = "/"
 
@@ -266,6 +284,30 @@ def handler(user: Model) -> Model:
     assert json.loads(result["body"]) == {"name": "John", "age": 30}
 
 
+def test_validate_body_param_with_invalid_date():
+    # GIVEN an APIGatewayRestResolver with validation enabled
+    app = APIGatewayRestResolver(enable_validation=True)
+
+    class Model(BaseModel):
+        name: str
+        age: int
+
+    # WHEN a handler is defined with a body parameter
+    @app.post("/")
+    def handler(user: Model) -> Model:
+        return user
+
+    LOAD_GW_EVENT["httpMethod"] = "POST"
+    LOAD_GW_EVENT["path"] = "/"
+    LOAD_GW_EVENT["body"] = "{"  # invalid JSON
+
+    # THEN the handler should be invoked and return 422
+    # THEN the body must have the "json_invalid" error message
+    result = app(LOAD_GW_EVENT, {})
+    assert result["statusCode"] == 422
+    assert "json_invalid" in result["body"]
+
+
 def test_validate_embed_body_param():
     # GIVEN an APIGatewayRestResolver with validation enabled
     app = APIGatewayRestResolver(enable_validation=True)