Skip to content

Commit 973b8f2

Browse files
author
Michal Ploski
committed
Rename root logger to registered logger to avoid naming collision with real root logger
1 parent ffeeebf commit 973b8f2

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

aws_lambda_powertools/logging/utils.py

+9-9
Original file line numberDiff line numberDiff line change
@@ -14,26 +14,26 @@ def copy_config_to_registered_loggers(
1414
Attach source logger handlers to external loggers.
1515
Modify logger level based on source logger attribute.
1616
"""
17-
root_loggers = _find_root_loggers(source_logger, exclude, include)
18-
for logger in root_loggers:
17+
registered_loggers = _find_registered_loggers(source_logger, exclude, include)
18+
for logger in registered_loggers:
1919
_configure_logger(source_logger, logger)
2020

2121

22-
def _include_root_loggers_filter(logger_list: List[str]):
22+
def _include_registered_loggers_filter(logger_list: List[str]):
2323
return [
2424
logging.getLogger(name) for name in logging.root.manager.loggerDict if "." not in name and name in logger_list
2525
]
2626

2727

28-
def _exclude_root_loggers_filter(logger_list: List[str]) -> List[logging.Logger]:
28+
def _exclude_registered_loggers_filter(logger_list: List[str]) -> List[logging.Logger]:
2929
return [
3030
logging.getLogger(name)
3131
for name in logging.root.manager.loggerDict
3232
if "." not in name and name not in logger_list
3333
]
3434

3535

36-
def _find_root_loggers(
36+
def _find_registered_loggers(
3737
source_logger: PowertoolsLogger, exclude: Optional[List[str]] = None, include: Optional[List[str]] = None
3838
) -> list[logging.Logger]:
3939
"""Filter root loggers based on provided parameters.
@@ -42,15 +42,15 @@ def _find_root_loggers(
4242
"""
4343
root_loggers = []
4444
if include and not exclude:
45-
root_loggers = _include_root_loggers_filter(logger_list=include)
45+
root_loggers = _include_registered_loggers_filter(logger_list=include)
4646
elif include and exclude:
4747
exclude = [source_logger.name, *exclude]
48-
root_loggers = _include_root_loggers_filter(logger_list=list(set(include) - set(exclude)))
48+
root_loggers = _include_registered_loggers_filter(logger_list=list(set(include) - set(exclude)))
4949
elif not include and exclude:
5050
exclude = [source_logger.name, *exclude]
51-
root_loggers = _exclude_root_loggers_filter(logger_list=exclude)
51+
root_loggers = _exclude_registered_loggers_filter(logger_list=exclude)
5252
else:
53-
root_loggers = _exclude_root_loggers_filter(logger_list=[source_logger.name])
53+
root_loggers = _exclude_registered_loggers_filter(logger_list=[source_logger.name])
5454

5555
source_logger.debug(f"Filtered root loggers: {root_loggers}")
5656
return root_loggers

0 commit comments

Comments
 (0)