Skip to content

Commit 85faa67

Browse files
Gerald W. LesterGerald W. Lester
Gerald W. Lester
authored and
Gerald W. Lester
committed
Fix for but 714 -- only evaluting first rule
1 parent 68e2c8e commit 85faa67

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

aws_lambda_powertools/utilities/feature_flags/feature_flags.py

+3-4
Original file line numberDiff line numberDiff line change
@@ -98,10 +98,9 @@ def _evaluate_rules(
9898
if self._evaluate_conditions(rule_name=rule_name, feature_name=feature_name, rule=rule, context=context):
9999
return bool(rule_match_value)
100100

101-
# no rule matched, return default value of feature
102-
logger.debug(f"no rule matched, returning feature default, default={feat_default}, name={feature_name}")
103-
return feat_default
104-
return False
101+
# no rule matched, return default value of feature
102+
logger.debug(f"no rule matched, returning feature default, default={feat_default}, name={feature_name}")
103+
return feat_default
105104

106105
def get_configuration(self) -> Union[Dict[str, Dict], Dict]:
107106
"""Get validated feature flag schema from configured store.

0 commit comments

Comments
 (0)