Skip to content

Commit 80739fd

Browse files
Reveting possible breaking change
1 parent 024db25 commit 80739fd

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

aws_lambda_powertools/tracing/base.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,13 @@ class BaseSegment(abc.ABC):
1010
"""Holds common properties and methods on segment and subsegment."""
1111

1212
@abc.abstractmethod
13-
def close(self, end_time: Optional[float] = None):
13+
def close(self, end_time: Optional[int] = None):
1414
"""Close the trace entity by setting `end_time`
1515
and flip the in progress flag to False.
1616
1717
Parameters
1818
----------
19-
end_time: float
19+
end_time: int
2020
Time in epoch seconds, by default current time will be used.
2121
"""
2222

aws_lambda_powertools/tracing/tracer.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -747,7 +747,7 @@ def _add_response_as_metadata(
747747
method name to add as metadata key, by default None
748748
data : Any, optional
749749
data to add as subsegment metadata, by default None
750-
subsegment : BaseSegment, optional
750+
subsegment : BaseSpan, optional
751751
existing subsegment to add metadata on, by default None
752752
capture_response : bool, optional
753753
Do not include response as metadata
@@ -771,7 +771,7 @@ def _add_full_exception_as_metadata(
771771
method name to add as metadata key, by default None
772772
error : Exception
773773
error to add as subsegment metadata, by default None
774-
subsegment : BaseSegment
774+
subsegment : BaseSpan
775775
existing subsegment to add metadata on, by default None
776776
capture_error : bool, optional
777777
Do not include error as metadata, by default True

0 commit comments

Comments
 (0)