fix(ci): on_label permissioning model & workflow execution

Author: heitorlessa

.github/scripts/comment_on_large_pr.js

@@ -1,14 +1,16 @@
 const {
   PR_NUMBER,
+  PR_ACTION,
   PR_AUTHOR,
   IGNORE_AUTHORS,
 } = require("./constants")
 
-module.exports = async ({github, context, core}) => {
-    if (IGNORE_AUTHORS.includes(PR_AUTHOR)) {
-      return core.notice("Author in IGNORE_AUTHORS list; skipping...")
-    }
 
+const notifyAuthor = async ({
+  gh_client,
+  owner,
+  repository,
+}) => {
     core.info(`Commenting on PR ${PR_NUMBER}`)
 
     let msg = `
@@ -17,10 +19,46 @@ module.exports = async ({github, context, core}) => {
     Please consider breaking into smaller PRs to avoid significant review delays. Ignore if this PR has naturally grown to this size after reviews.
     `;
 
-    await github.rest.issues.createComment({
+    try {
+      await gh_client.rest.issues.createComment({
+        owner: owner,
+        repo: repository,
+        body: msg,
+        issue_number: PR_NUMBER,
+      });
+    } catch (error) {
+      core.setFailed("Failed to notify PR author to split large PR");
+      console.error(err);
+    }
+}
+
+module.exports = async ({github, context, core}) => {
+    if (IGNORE_AUTHORS.includes(PR_AUTHOR)) {
+      return core.notice("Author in IGNORE_AUTHORS list; skipping...")
+    }
+
+    if (PR_ACTION != "labeled") {
+      return core.notice("Only run on PRs labeling actions; skipping")
+    }
+
+
+    /** @type {string[]} */
+    const labels = await github.rest.issues.listLabelsOnIssue({
       owner: context.repo.owner,
       repo: context.repo.repo,
-      body: msg,
       issue_number: PR_NUMBER,
-    });
+    })
+
+    // Schema: https://docs.github.com/en/rest/issues/labels#list-labels-for-an-issue
+    for (const label of labels) {
+      core.info(`Label: ${label}`)
+      if (label.name == "size/XXL") {
+        await notifyAuthor({
+          gh_client: github,
+          owner: context.repo.owner,
+          repository: context.repo.repo,
+        })
+        break;
+      }
+    }
 }

.github/workflows/on_label_added.yml

@@ -1,13 +1,23 @@
 name: On Label added
 
 on:
-  pull_request:
+  workflow_run:
+    workflows: ["Record PR details"]
     types:
-      - labeled
+      - completed
 
 jobs:
+  get_pr_details:
+    if: ${{ github.event.workflow_run.conclusion == 'success' }}
+    uses: ./.github/workflows/reusable_export_pr_details.yml
+    with:
+      record_pr_workflow_id: ${{ github.event.workflow_run.id }}
+      workflow_origin: ${{ github.event.repository.full_name }}
+    secrets:
+      token: ${{ secrets.GITHUB_TOKEN }}
+
   split-large-pr:
-    if: ${{ github.event.label.name == 'size/XXL' }}
+    needs: get_pr_details
     runs-on: ubuntu-latest
     permissions:
       issues: write
@@ -17,8 +27,9 @@ jobs:
       - name: "Suggest split large Pull Request"
         uses: actions/github-script@v6
         env:
-          PR_NUMBER: ${{ github.event.pull_request.number }}
-          PR_AUTHOR: ${{ github.event.pull_request.user.login }}
+          PR_NUMBER: ${{ needs.get_pr_details.outputs.prNumber }}
+          PR_ACTION: ${{ needs.get_pr_details.outputs.prAction }}
+          PR_AUTHOR: ${{ needs.get_pr_details.outputs.prAuthor }}
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
           script: |