Skip to content

Commit 51558cf

Browse files
committed
fix: repurpose test to cover parent loggers case
1 parent e4f8fa8 commit 51558cf

File tree

1 file changed

+13
-20
lines changed

1 file changed

+13
-20
lines changed

tests/functional/test_logger_utils.py

+13-20
Original file line numberDiff line numberDiff line change
@@ -195,32 +195,25 @@ def test_copy_config_to_ext_loggers_should_not_break_append_keys(stdout, log_lev
195195
powertools_logger.append_keys(key="value")
196196

197197

198-
def test_copy_config_to_ext_loggers_child_loggers_append_after_works(stdout):
199-
# GIVEN powertools logger AND child initialized AND
200-
201-
# GIVEN Loggers are initialized
202-
# create child logger before parent to mimick
203-
# importing logger from another module/file
204-
# as loggers are created in global scope
198+
def test_copy_config_to_parent_loggers_only(stdout):
199+
# GIVEN Powertools Logger and Child Logger are initialized
200+
# and Powertools Logger config is copied over
205201
service = service_name()
206202
child = Logger(stream=stdout, service=service, child=True)
207203
parent = Logger(stream=stdout, service=service)
208-
209-
# WHEN a child Logger adds an additional key AND parent logger adds additional key
210-
# AND configuration copied from powertools logger
211-
# AND powertools logger and child logger used
212204
utils.copy_config_to_registered_loggers(source_logger=parent)
213-
child.structure_logs(append=True, customer_id="value")
214-
parent.structure_logs(append=True, user_id="value")
215-
parent.warning("Logger message")
216-
child.warning("Child logger message")
217205

218-
# THEN payment_id key added to both powertools logger and child logger
206+
# WHEN either parent or child logger append keys
207+
child.append_keys(customer_id="value")
208+
parent.append_keys(user_id="value")
209+
parent.info("Logger message")
210+
child.info("Child logger message")
211+
212+
# THEN both custom keys should be propagated bi-directionally in parent and child loggers
213+
# as child logger won't be touched when config is being copied
219214
parent_log, child_log = capture_multiple_logging_statements_output(stdout)
220-
assert "customer_id" in parent_log
221-
assert "customer_id" in child_log
222-
assert "user_id" in parent_log
223-
assert "user_id" in child_log
215+
assert "customer_id" in parent_log, child_log
216+
assert "user_id" in parent_log, child_log
224217
assert child.parent.name == service
225218

226219

0 commit comments

Comments
 (0)