improv: update tests to include non-truthy choice var

Author: heitorlessa

aws_lambda_powertools/shared/functions.py

@@ -1,9 +1,42 @@
 from distutils.util import strtobool
+from typing import Any, Union
 
 
-def resolve_truthy_env_var_choice(env: str, choice: bool = None) -> bool:
+def resolve_truthy_env_var_choice(env: Any, choice: bool = None) -> bool:
+    """ Pick explicit choice over truthy env value, if available, otherwise return truthy env value
+
+    NOTE: Environment variable should be resolved by the caller.
+
+    Parameters
+    ----------
+    env : Any
+        environment variable actual value
+    choice : bool
+        explicit choice
+
+    Returns
+    -------
+    choice : str
+        resolved choice as either bool or environment value
+    """
     return choice if choice is not None else strtobool(env)
 
 
-def resolve_env_var_choice(env: str, choice: bool = None) -> bool:
+def resolve_env_var_choice(env: Any, choice: bool = None) -> Union[bool, Any]:
+    """ Pick explicit choice over env, if available, otherwise return env value received
+
+    NOTE: Environment variable should be resolved by the caller.
+
+    Parameters
+    ----------
+    env : Any
+        environment variable actual value
+    choice : bool
+        explicit choice
+
+    Returns
+    -------
+    choice : str
+        resolved choice as either bool or environment value
+    """
     return choice if choice is not None else env

tests/functional/test_shared_functions.py

@@ -1,9 +1,11 @@
-from aws_lambda_powertools.shared.functions import resolve_truthy_env_var_choice
+from aws_lambda_powertools.shared.functions import resolve_env_var_choice, resolve_truthy_env_var_choice
 
 
 def test_resolve_env_var_choice_explicit_wins_over_env_var():
     assert resolve_truthy_env_var_choice(env="true", choice=False) is False
+    assert resolve_env_var_choice(env="something", choice=False) is False
 
 
 def test_resolve_env_var_choice_env_wins_over_absent_explicit():
     assert resolve_truthy_env_var_choice(env="true") == 1
+    assert resolve_env_var_choice(env="something") == "something"