Adding more tests

Author: leandrodamascena

aws_lambda_powertools/utilities/idempotency/idempotency.py

@@ -10,13 +10,13 @@
 
 from aws_lambda_powertools.middleware_factory import lambda_handler_decorator
 from aws_lambda_powertools.shared import constants
+from aws_lambda_powertools.shared.functions import strtobool
 from aws_lambda_powertools.shared.types import AnyCallableT
 from aws_lambda_powertools.utilities.idempotency.base import IdempotencyHandler
 from aws_lambda_powertools.utilities.idempotency.config import IdempotencyConfig
 from aws_lambda_powertools.utilities.idempotency.persistence.base import (
     BasePersistenceLayer,
 )
-from aws_lambda_powertools.shared.functions import strtobool
 from aws_lambda_powertools.utilities.idempotency.serialization.base import (
     BaseIdempotencyModelSerializer,
     BaseIdempotencySerializer,
@@ -67,7 +67,9 @@ def idempotent(
         >>>     return {"StatusCode": 200}
     """
 
-    if strtobool(os.getenv(constants.IDEMPOTENCY_DISABLED_ENV, "0")):
+    # Check if the IDEMPOTENCY_DISABLED_ENV environment variable is set to True
+    # If IDEMPOTENCY_DISABLED_ENV is not set or set to any false value, the function will be idempotent by default
+    if strtobool(os.getenv(constants.IDEMPOTENCY_DISABLED_ENV, "false")):
         return handler(event, context, **kwargs)
 
     config = config or IdempotencyConfig()
@@ -151,6 +153,8 @@ def process_order(customer_id: str, order: dict, **kwargs):
 
     @functools.wraps(function)
     def decorate(*args, **kwargs):
+        # Check if the IDEMPOTENCY_DISABLED_ENV environment variable is set to True
+        # If IDEMPOTENCY_DISABLED_ENV is not set or set to any false value, the function will be idempotent by default
         if strtobool(os.getenv(constants.IDEMPOTENCY_DISABLED_ENV, "0")):
             return function(*args, **kwargs)
 

tests/functional/idempotency/test_idempotency.py

@@ -1667,13 +1667,19 @@ def dummy(payload):
     dummy(payload=data_two)
 
 
-def test_idempotency_disabled_envvar(monkeypatch, lambda_context, persistence_store: DynamoDBPersistenceLayer):
+@pytest.mark.parametrize("idempotency_disabled_value", ["1", "y", "yes", "t", "true", "on"])
+def test_idempotency_enabled_envvar(
+    monkeypatch,
+    lambda_context,
+    persistence_store: DynamoDBPersistenceLayer,
+    idempotency_disabled_value,
+):
     # Scenario to validate no requests sent to dynamodb table when 'POWERTOOLS_IDEMPOTENCY_DISABLED' is set
     mock_event = {"data": "value"}
 
     persistence_store.client = MagicMock()
 
-    monkeypatch.setenv("POWERTOOLS_IDEMPOTENCY_DISABLED", "1")
+    monkeypatch.setenv("POWERTOOLS_IDEMPOTENCY_DISABLED", str(idempotency_disabled_value))
 
     @idempotent_function(data_keyword_argument="data", persistence_store=persistence_store)
     def dummy(data):
@@ -1689,6 +1695,34 @@ def dummy_handler(event, context):
     assert len(persistence_store.client.method_calls) == 0
 
 
+@pytest.mark.parametrize("idempotency_disabled_value", ["0", "n", "no", "f", "false", "off"])
+def test_idempotency_disabled_envvar(
+    monkeypatch,
+    lambda_context,
+    persistence_store: DynamoDBPersistenceLayer,
+    idempotency_disabled_value,
+):
+    # Scenario to validate no requests sent to dynamodb table when 'POWERTOOLS_IDEMPOTENCY_DISABLED' is false
+    mock_event = {"data": "value"}
+
+    persistence_store.client = MagicMock()
+
+    monkeypatch.setenv("POWERTOOLS_IDEMPOTENCY_DISABLED", str(idempotency_disabled_value))
+
+    @idempotent_function(data_keyword_argument="data", persistence_store=persistence_store)
+    def dummy(data):
+        return {"message": "hello"}
+
+    @idempotent(persistence_store=persistence_store)
+    def dummy_handler(event, context):
+        return {"message": "hi"}
+
+    dummy(data=mock_event)
+    dummy_handler(mock_event, lambda_context)
+
+    assert len(persistence_store.client.method_calls) == 4
+
+
 @pytest.mark.parametrize("idempotency_config", [{"use_local_cache": True}], indirect=True)
 def test_idempotent_function_duplicates(
     idempotency_config: IdempotencyConfig,