Skip to content

Commit 392c568

Browse files
heitorlessasthulb
authored andcommitted
fix(shared): move to static version bumping to prevent issues with customers custom builds (#2386)
1 parent 7c850ba commit 392c568

File tree

5 files changed

+26
-176
lines changed

5 files changed

+26
-176
lines changed

Diff for: .github/workflows/release.yml

+5-3
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,9 @@ jobs:
7878

7979
# We use a pinned version of Poetry to be certain it won't modify source code before we create a hash
8080
- name: Install poetry
81-
run: pipx install git+https://github.com/python-poetry/poetry@68b88e5390720a3dd84f02940ec5200bfce39ac6 # v1.5.0
81+
run: |
82+
pipx install git+https://github.com/python-poetry/poetry@68b88e5390720a3dd84f02940ec5200bfce39ac6 # v1.5.0
83+
pipx inject poetry git+https://github.com/monim67/poetry-bumpversion@ef49c63acef7fe8680789ddb31f376cc898f0012 # v0.3.0
8284
8385
- name: Bump package version
8486
id: versioning
@@ -291,7 +293,7 @@ jobs:
291293
292294
- name: Create Git Tag
293295
run: |
294-
git add pyproject.toml
296+
git add pyproject.toml aws_lambda_powertools/shared/version.py
295297
git commit -m "chore: version bump"
296298
git tag -a v"${RELEASE_VERSION}" -m "release_version: v${RELEASE_VERSION}"
297299
git push origin v"${RELEASE_VERSION}"
@@ -332,7 +334,7 @@ jobs:
332334
id: create-pr
333335
uses: ./.github/actions/create-pr
334336
with:
335-
files: "pyproject.toml"
337+
files: "pyproject.toml aws_lambda_powertools/shared/version.py"
336338
temp_branch_prefix: "ci-bump"
337339
pull_request_title: "chore(ci): bump version to ${{ needs.seal.outputs.RELEASE_VERSION }}"
338340
github_token: ${{ secrets.GITHUB_TOKEN }}

Diff for: Makefile

+6
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,13 @@ target:
66

77
dev:
88
pip install --upgrade pip pre-commit poetry
9+
@$(MAKE) dev-version-plugin
910
poetry install --extras "all"
1011
pre-commit install
1112

1213
dev-gitpod:
1314
pip install --upgrade pip poetry
15+
@$(MAKE) dev-version-plugin
1416
poetry install --extras "all"
1517
pre-commit install
1618

@@ -106,3 +108,7 @@ changelog:
106108

107109
mypy:
108110
poetry run mypy --pretty aws_lambda_powertools examples
111+
112+
113+
dev-version-plugin:
114+
poetry self add git+https://github.com/monim67/poetry-bumpversion@ef49c63acef7fe8680789ddb31f376cc898f0012

Diff for: aws_lambda_powertools/shared/version.py

+2-15
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,3 @@
1-
"""
2-
This file serves to create a constant that informs
3-
the current version of the Powertools package and exposes it in the main module
1+
"""Exposes version constant to avoid circular dependencies."""
42

5-
Since Python 3.8 there the built-in importlib.metadata
6-
When support for Python3.7 is dropped, we can remove the optional importlib_metadata dependency
7-
See: https://docs.python.org/3/library/importlib.metadata.html
8-
"""
9-
import sys
10-
11-
if sys.version_info >= (3, 8):
12-
from importlib.metadata import version
13-
else:
14-
from importlib_metadata import version
15-
16-
VERSION = version("aws-lambda-powertools")
3+
VERSION = "2.16.1"

0 commit comments

Comments
 (0)