Skip to content

Commit 3569e21

Browse files
committed
feat: make arguments explicits in parameter utilities
1 parent de842a8 commit 3569e21

File tree

2 files changed

+3
-12
lines changed

2 files changed

+3
-12
lines changed

aws_lambda_powertools/utilities/parameters/dynamodb.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ def _get(self, name: str, **kwargs) -> str:
4343

4444
return self.table.get_item(Key={self.key_attr: name})["Item"][self.value_attr]
4545

46-
def _get_multiple(self, path: str, **kwargs) -> Dict[str, str]:
46+
def _get_multiple(self, path: str, sort_attr: str = "sk", **kwargs) -> Dict[str, str]:
4747
"""
4848
Retrieve multiple parameter values from Amazon DynamoDB
4949
@@ -55,8 +55,6 @@ def _get_multiple(self, path: str, **kwargs) -> Dict[str, str]:
5555
Name of the DynamoDB table sort key (defaults to 'sk')
5656
"""
5757

58-
sort_attr = kwargs.get("sort_attr", "sk")
59-
6058
response = self.table.query(KeyConditionExpression=Key(self.key_attr).eq(path))
6159
items = response.get("Items", [])
6260

aws_lambda_powertools/utilities/parameters/ssm.py

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ def __init__(
3030

3131
super().__init__()
3232

33-
def _get(self, name: str, **kwargs) -> str:
33+
def _get(self, name: str, decrypt: bool = False, **kwargs) -> str:
3434
"""
3535
Retrieve a parameter value from AWS Systems Manager Parameter Store
3636
@@ -42,12 +42,9 @@ def _get(self, name: str, **kwargs) -> str:
4242
If the parameter value should be decrypted
4343
"""
4444

45-
# Load kwargs
46-
decrypt = kwargs.get("decrypt", False)
47-
4845
return self.client.get_parameter(Name=name, WithDecryption=decrypt)["Parameter"]["Value"]
4946

50-
def _get_multiple(self, path: str, **kwargs) -> Dict[str, str]:
47+
def _get_multiple(self, path: str, decrypt: bool = False, recursive: bool = False, **kwargs) -> Dict[str, str]:
5148
"""
5249
Retrieve multiple parameter values from AWS Systems Manager Parameter Store
5350
@@ -61,10 +58,6 @@ def _get_multiple(self, path: str, **kwargs) -> Dict[str, str]:
6158
If this should retrieve the parameter values recursively or not
6259
"""
6360

64-
# Load kwargs
65-
decrypt = kwargs.get("decrypt", False)
66-
recursive = kwargs.get("recursive", False)
67-
6861
response = self.client.get_parameters_by_path(Path=path, WithDecryption=decrypt, Recursive=recursive)
6962
parameters = response.get("Parameters", [])
7063

0 commit comments

Comments
 (0)