Skip to content

Commit 287442d

Browse files
committed
fix(ci): move conditionals from yaml to code; leftover
1 parent 37d9447 commit 287442d

File tree

2 files changed

+0
-7
lines changed

2 files changed

+0
-7
lines changed

.github/workflows/on_merged_pr.yml

-4
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,6 @@ jobs:
1616
token: ${{ secrets.GITHUB_TOKEN }}
1717
release_label_on_merge:
1818
needs: get_pr_details
19-
# Maintenance: Conditional isn't working as expected
20-
if: |
21-
needs.get_pr_details.outputs.prAuthor != 'dependabot[bot]'
22-
&& needs.get_pr_details.outputs.prIsMerged == true
2319
runs-on: ubuntu-latest
2420
steps:
2521
- name: Debug outputs

.github/workflows/on_opened_pr.yml

-3
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ on:
66
types:
77
- completed
88

9-
109
jobs:
1110
get_pr_details:
1211
if: ${{ github.event.workflow_run.conclusion == 'success' }}
@@ -23,8 +22,6 @@ jobs:
2322
run: echo "Outputs ${{ toJSON(needs.get_pr_details.outputs) }}"
2423
- uses: actions/checkout@v3
2524
- name: "Ensure related issue is present"
26-
if: contains('["opened", "edited"]', needs.get_pr_details.outputs.prAction)
27-
if: needs.get_pr_details.outputs.prAction == 'opened' || needs.get_pr_details.outputs.prAction == 'edited'
2825
uses: actions/github-script@v6
2926
env:
3027
PR_BODY: ${{ needs.get_pr_details.outputs.prBody }}

0 commit comments

Comments
 (0)