fix: improve coverage of params.py

Author: rubenfonseca

aws_lambda_powertools/event_handler/openapi/dependant.py

@@ -258,7 +258,7 @@ def get_flat_params(dependant: Dependant) -> List[ModelField]:
         A list of ModelField objects containing the flat parameters from the Dependant object.
 
     """
-    flat_dependant = get_flat_dependant(dependant, skip_repeats=True)
+    flat_dependant = get_flat_dependant(dependant)
     return (
         flat_dependant.path_params
         + flat_dependant.query_params

aws_lambda_powertools/event_handler/openapi/params.py

@@ -47,7 +47,6 @@ def __init__(
         cookie_params: Optional[List[ModelField]] = None,
         body_params: Optional[List[ModelField]] = None,
         return_param: Optional[ModelField] = None,
-        dependencies: Optional[List["Dependant"]] = None,
         name: Optional[str] = None,
         call: Optional[Callable[..., Any]] = None,
         request_param_name: Optional[str] = None,
@@ -63,7 +62,6 @@ def __init__(
         self.cookie_params = cookie_params or []
         self.body_params = body_params or []
         self.return_param = return_param or None
-        self.dependencies = dependencies or []
         self.request_param_name = request_param_name
         self.websocket_param_name = websocket_param_name
         self.http_connection_param_name = http_connection_param_name
@@ -618,8 +616,6 @@ def __init__(
 
 def get_flat_dependant(
     dependant: Dependant,
-    *,
-    skip_repeats: bool = False,
     visited: Optional[List[CacheKey]] = None,
 ) -> Dependant:
     """
@@ -647,27 +643,14 @@ def get_flat_dependant(
         visited = []
     visited.append(dependant.cache_key)
 
-    flat_dependant = Dependant(
+    return Dependant(
         path_params=dependant.path_params.copy(),
         query_params=dependant.query_params.copy(),
         header_params=dependant.header_params.copy(),
         cookie_params=dependant.cookie_params.copy(),
         body_params=dependant.body_params.copy(),
         path=dependant.path,
     )
-    for sub_dependant in dependant.dependencies:
-        if skip_repeats and sub_dependant.cache_key in visited:
-            continue
-
-        flat_sub = get_flat_dependant(sub_dependant, skip_repeats=skip_repeats, visited=visited)
-
-        flat_dependant.path_params.extend(flat_sub.path_params)
-        flat_dependant.query_params.extend(flat_sub.query_params)
-        flat_dependant.header_params.extend(flat_sub.header_params)
-        flat_dependant.cookie_params.extend(flat_sub.cookie_params)
-        flat_dependant.body_params.extend(flat_sub.body_params)
-
-    return flat_dependant
 
 
 def analyze_param(

tests/functional/event_handler/test_openapi_params.py

@@ -11,7 +11,14 @@
     ParameterInType,
     Schema,
 )
-from aws_lambda_powertools.event_handler.openapi.params import Body, Query
+from aws_lambda_powertools.event_handler.openapi.params import (
+    Body,
+    Header,
+    Param,
+    ParamTypes,
+    Query,
+    _create_model_field,
+)
 from aws_lambda_powertools.shared.types import Annotated
 
 JSON_CONTENT_TYPE = "application/json"
@@ -274,3 +281,35 @@ def handler(user: Annotated[User, Body(embed=True)]):
     assert "Body_handler_users_post" in components.schemas
     body_post_handler_schema = components.schemas["Body_handler_users_post"]
     assert body_post_handler_schema.properties["user"].ref == "#/components/schemas/User"
+
+
+def test_create_header():
+    header = Header(convert_underscores=True)
+    assert header.convert_underscores is True
+
+
+def test_create_body():
+    body = Body(embed=True, examples=[Example(summary="Example 1", value=10)])
+    assert body.embed is True
+
+
+# Tests that when we try to create a model without a field type, we return None
+def test_create_empty_model_field():
+    result = _create_model_field(None, int, "name", False)
+    assert result is None
+
+
+# Tests that when we try to crate a param model without a source, we default to "query"
+def test_create_model_field_with_empty_in():
+    field_info = Param()
+
+    result = _create_model_field(field_info, int, "name", False)
+    assert result.field_info.in_ == ParamTypes.query
+
+
+# Tests that when we try to create a model field with convert_underscore, we convert the field name
+def test_create_model_field_convert_underscore():
+    field_info = Header(alias=None, convert_underscores=True)
+
+    result = _create_model_field(field_info, int, "user_id", False)
+    assert result.alias == "user-id"