test(feature-toggles): Add schema tests

Author: Michael Brewer

aws_lambda_powertools/utilities/feature_toggles/schema.py

@@ -1,4 +1,5 @@
 from enum import Enum
+from logging import Logger
 from typing import Any, Dict
 
 from .exceptions import ConfigurationError
@@ -22,7 +23,7 @@ class ACTION(str, Enum):
 
 
 class SchemaValidator:
-    def __init__(self, logger: object):
+    def __init__(self, logger: Logger):
         self._logger = logger
 
     def _raise_conf_exc(self, error_str: str) -> None:
@@ -47,7 +48,7 @@ def _validate_rule(self, feature_name: str, rule: Dict[str, Any]) -> None:
             self._raise_conf_exc(f"feature rule is not a dictionary, feature_name={feature_name}")
         rule_name = rule.get(RULE_NAME_KEY)
         if not rule_name or rule_name is None or not isinstance(rule_name, str):
-            self._raise_conf_exc(f"invalid rule_name, feature_name={feature_name}")
+            return self._raise_conf_exc(f"invalid rule_name, feature_name={feature_name}")
         rule_default_value = rule.get(RULE_DEFAULT_VALUE)
         if rule_default_value is None or not isinstance(rule_default_value, bool):
             self._raise_conf_exc(f"invalid rule_default_value, rule_name={rule_name}")
@@ -76,8 +77,8 @@ def _validate_feature(self, feature_name: str, feature_dict_def: Dict[str, Any])
     def validate_json_schema(self, schema: Dict[str, Any]) -> None:
         if not isinstance(schema, dict):
             self._raise_conf_exc("invalid AWS AppConfig JSON schema detected, root schema is not a dictionary")
-        features_dict: Dict = schema.get(FEATURES_KEY)
+        features_dict = schema.get(FEATURES_KEY)
         if not isinstance(features_dict, dict):
-            self._raise_conf_exc("invalid AWS AppConfig JSON schema detected, missing features dictionary")
+            return self._raise_conf_exc("invalid AWS AppConfig JSON schema detected, missing features dictionary")
         for feature_name, feature_dict_def in features_dict.items():
             self._validate_feature(feature_name, feature_dict_def)

tests/functional/feature_toggles/test_schema_validation.py

@@ -262,3 +262,69 @@ def test_valid_condition_all_actions():
         },
     }
     validator.validate_json_schema(schema)
+
+
+def test_validate_condition_invalid_condition_type():
+    # GIVEN an invalid condition type of empty dict
+    validator = SchemaValidator(logger)
+    condition = {}
+
+    # WHEN calling _validate_condition
+    with pytest.raises(ConfigurationError) as err:
+        validator._validate_condition("foo", condition)
+
+    # THEN raise ConfigurationError
+    assert "invalid condition type" in str(err)
+
+
+def test_validate_condition_invalid_condition_action():
+    # GIVEN an invalid condition action of foo
+    validator = SchemaValidator(logger)
+    condition = {"action": "foo"}
+
+    # WHEN calling _validate_condition
+    with pytest.raises(ConfigurationError) as err:
+        validator._validate_condition("foo", condition)
+
+    # THEN raise ConfigurationError
+    assert "invalid action value" in str(err)
+
+
+def test_validate_condition_invalid_condition_key():
+    # GIVEN a configuration with a missing "key"
+    validator = SchemaValidator(logger)
+    condition = {"action": ACTION.EQUALS.value}
+
+    # WHEN calling _validate_condition
+    with pytest.raises(ConfigurationError) as err:
+        validator._validate_condition("foo", condition)
+
+    # THEN raise ConfigurationError
+    assert "invalid key value" in str(err)
+
+
+def test_validate_condition_missing_condition_value():
+    # GIVEN a configuration with a missing condition value
+    validator = SchemaValidator(logger)
+    condition = {"action": ACTION.EQUALS.value, "key": "Foo"}
+
+    # WHEN calling _validate_condition
+    with pytest.raises(ConfigurationError) as err:
+        validator._validate_condition("foo", condition)
+
+    # THEN raise ConfigurationError
+    assert "missing condition value" in str(err)
+
+
+def test_validate_rule_invalid_rule_name():
+    # GIVEN a rule_name not in the rule dict
+    validator = SchemaValidator(logger)
+    rule_name = "invalid_rule_name"
+    rule = {"missing": ""}
+
+    # WHEN calling _validate_rule
+    with pytest.raises(ConfigurationError) as err:
+        validator._validate_rule(rule_name, rule)
+
+    # THEN raise ConfigurationError
+    assert "invalid rule_name" in str(err)