Adding nox to run tests with specific dependencies

Author: leandrodamascena

.github/workflows/quality_check.yml

@@ -68,6 +68,8 @@ jobs:
         run: make mypy
       - name: Test with pytest
         run: make test
+      - name: Test dependencies with Nox
+        run: make nox
       - name: Security baseline
         run: make security-baseline
       - name: Complexity baseline

Makefile

@@ -32,6 +32,9 @@ test:
 	poetry run pytest -m "not perf" --ignore tests/e2e --cov=aws_lambda_powertools --cov-report=xml
 	poetry run pytest --cache-clear tests/performance
 
+nox:
+	poetry run nox --error-on-external-run --reuse-venv=yes --non-interactive
+
 test-pydanticv2:
 	poetry run pytest -m "not perf" --ignore tests/e2e
 

poetry.lock

@@ -126,6 +126,7 @@ pytest-socket = ">=0.6,<0.8"
 types-redis = "^4.6.0.7"
 testcontainers = { extras = ["redis"], version = "^3.7.1" }
 multiprocess = "^0.70.16"
+nox = "^2024.4.15"
 
 [tool.coverage.run]
 source = ["aws_lambda_powertools"]

pyproject.toml

@@ -15,7 +15,7 @@
 
 import pytest
 
-from aws_lambda_powertools import Logger, Tracer, set_package_logger_handler
+from aws_lambda_powertools import Logger, Metrics, set_package_logger_handler
 from aws_lambda_powertools.logging import correlation_paths
 from aws_lambda_powertools.logging.exceptions import InvalidLoggerSamplingRateError
 from aws_lambda_powertools.logging.formatter import (
@@ -219,13 +219,14 @@ def test_package_logger_stream(stdout):
     # GIVEN package logger "aws_lambda_powertools" is explicitly set with no params
     set_package_logger(stream=stdout)
 
-    # WHEN Tracer is initialized in disabled mode
-    Tracer(disabled=True)
+    # WHEN we add a dimension in Metrics feature
+    my_metrics = Metrics(namespace="powertools")
+    my_metrics.add_dimension(name="dimension", value="test")
 
-    # THEN Tracer debug log statement should be logged
+    # THEN Metrics debug log statement should be logged
     output = stdout.getvalue()
     logger = logging.getLogger("aws_lambda_powertools")
-    assert "Tracing has been disabled" in output
+    assert "Adding dimension:" in output
     assert logger.level == logging.DEBUG
 
 
@@ -235,10 +236,11 @@ def test_package_logger_format(capsys):
     formatter = logging.Formatter("message=%(message)s")
     set_package_logger(formatter=formatter)
 
-    # WHEN Tracer is initialized in disabled mode
-    Tracer(disabled=True)
+    # WHEN we add a dimension in Metrics feature
+    my_metrics = Metrics(namespace="powertools")
+    my_metrics.add_dimension(name="dimension", value="test")
 
-    # THEN Tracer debug log statement should be logged using `message=` format
+    # THEN Metrics debug log statement should be logged using `message=` format
     output = capsys.readouterr().out
     logger = logging.getLogger("aws_lambda_powertools")
     assert "message=" in output
@@ -977,13 +979,15 @@ def test_set_package_logger_handler_with_powertools_debug_env_var(stdout, monkey
     logger = logging.getLogger("aws_lambda_powertools")
 
     # WHEN set_package_logger is used at initialization
-    # and any Powertools for AWS Lambda (Python) operation is used (e.g., Tracer)
+    # and any Powertools for AWS Lambda (Python) operation is used (e.g., Metrics add_dimension)
     set_package_logger_handler(stream=stdout)
-    Tracer(disabled=True)
 
-    # THEN Tracer debug log statement should be logged
+    my_metrics = Metrics(namespace="powertools")
+    my_metrics.add_dimension(name="dimension", value="test")
+
+    # THEN Metrics debug log statement should be logged
     output = stdout.getvalue()
-    assert "Tracing has been disabled" in output
+    assert "Adding dimension:" in output
     assert logger.level == logging.DEBUG