Skip to content

feat: Add Batch Processor module #1317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 95 commits into from
Aug 4, 2023
Merged

feat: Add Batch Processor module #1317

merged 95 commits into from
Aug 4, 2023

Conversation

scottgerring
Copy link
Contributor

@scottgerring scottgerring commented Jul 26, 2023

Issue #, if available:
#797

Description of changes:

Adds a new module for batch processing messages from SQS, Kinesis Streams, and DynamoDB Streams, supporting examples, and documentation.

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@jeromevdl jeromevdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor things

scottgerring and others added 2 commits August 4, 2023 08:20
Co-authored-by: Jérôme Van Der Linden <[email protected]>
Co-authored-by: Jérôme Van Der Linden <[email protected]>
@aws-powertools aws-powertools deleted a comment from jeromevdl Aug 4, 2023
@scottgerring
Copy link
Contributor Author

@jeromevdl if E2E runs that should be it

Copy link
Contributor

@jeromevdl jeromevdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's almost ok, I think we should have some doc about the errorhandler, successhandler and a bit more on the raw vs deserialized data

@scottgerring
Copy link
Contributor Author

it's almost ok, I think we should have some doc about the errorhandler, successhandler and a bit more on the raw vs deserialized data

Added a whole new section at the bottom on the various ways you can configure your handlers!

Copy link
Contributor

@jeromevdl jeromevdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

come on, we are close to the end :)

scottgerring and others added 2 commits August 4, 2023 13:06
Co-authored-by: Jérôme Van Der Linden <[email protected]>
Address review comments
Copy link
Contributor

@jeromevdl jeromevdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 76 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@scottgerring scottgerring merged commit d0c7f91 into main Aug 4, 2023
@scottgerring scottgerring deleted the rfc-batch-processor branch August 4, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants