-
Notifications
You must be signed in to change notification settings - Fork 90
feat: Add Batch Processor module #1317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…' into rfc-batch-processor
062ca43
to
f91c2c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor things
powertools-e2e-tests/src/test/java/software/amazon/lambda/powertools/BatchE2ET.java
Outdated
Show resolved
Hide resolved
powertools-e2e-tests/src/test/java/software/amazon/lambda/powertools/BatchE2ET.java
Outdated
Show resolved
Hide resolved
powertools-e2e-tests/src/test/java/software/amazon/lambda/powertools/BatchE2ET.java
Show resolved
Hide resolved
...ools-e2e-tests/src/test/java/software/amazon/lambda/powertools/testutils/Infrastructure.java
Show resolved
Hide resolved
...ools-e2e-tests/src/test/java/software/amazon/lambda/powertools/testutils/Infrastructure.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Jérôme Van Der Linden <[email protected]>
Co-authored-by: Jérôme Van Der Linden <[email protected]>
@jeromevdl if E2E runs that should be it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's almost ok, I think we should have some doc about the errorhandler, successhandler and a bit more on the raw vs deserialized data
Added a whole new section at the bottom on the various ways you can configure your handlers! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
come on, we are close to the end :)
Co-authored-by: Jérôme Van Der Linden <[email protected]>
Address review comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Kudos, SonarCloud Quality Gate passed!
|
Issue #, if available:
#797
Description of changes:
Adds a new module for batch processing messages from SQS, Kinesis Streams, and DynamoDB Streams, supporting examples, and documentation.
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.