fix:Removing env var credentials provider as default. #1161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SnapStart uses a different credentials provider so when it is hardcoded like this, the default will fail.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1161 +/- ##
============================================
- Coverage 71.32% 71.20% -0.13%
Complexity 535 535
============================================
Files 70 71 +1
Lines 2239 2240 +1
Branches 237 240 +3
============================================
- Hits 1597 1595 -2
- Misses 529 532 +3
Partials 113 113
☔ View full report in Codecov by Sentry. |
SnapStart uses a different credentials provider so when it is hardcoded like this, the default will fail.
stevehouel
reviewed
May 16, 2023
| // AWS_LAMBDA_INITIALIZATION_TYPE has two values on-demand and snap-start | ||
| // when using snap-start mode, the env var creds provider isn't used and causes a fatal error | ||
| // fall back to the default provider chain if the mode is anything other than on-demand. | ||
| if (System.getenv().get(Constants.AWS_LAMBDA_INITIALIZATION_TYPE) == "on-demand") { |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
Problem: An equality operator (== or !=) is used to compare strings, which matches strings based on address.
Fix: Do content comparison using the equals() method to compare the values of the strings.
jeromevdl
reviewed
May 16, 2023
...tools-parameters/src/main/java/software/amazon/lambda/powertools/parameters/SSMProvider.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1160
Description of changes:
SnapStart uses a different credentials provider to on-demand, so when it is hardcoded like this, the default will fail.
Lambda sets the env var
AWS_LAMBDA_INITIALIZATION_TYPEto eithersnap-startoron-demanddepending on the mode. We can use this to configure the DynamoDB correctly.Testing this is difficult, the configuration isn't an open attribute, so I don't think I can write a unit test easily (please let me know if I'm wrong). An integration test would be best.
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.