Skip to content

Log4j2 and Lambda runtime issue which fails logger util in some scenario #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pankajagrawal16 opened this issue Apr 8, 2022 · 5 comments
Assignees
Labels
documentation Improvements or additions to documentation priority:2 High - core feature or affects 60% of the users

Comments

@pankajagrawal16
Copy link
Contributor

pankajagrawal16 commented Apr 8, 2022

What were you initially searching for in the docs?

This issue is created via discussions as part of aws-samples/aws-lambda-powertools-examples#67

Is this related to an existing part of the documentation? Please share a link

https://awslabs.github.io/aws-lambda-powertools-java/core/logging/

Describe how we could make it clearer

  • Update docs and samples to specify class names directly when initialising logger. Thats better from cold start perspective anyways.
  • Clarify and address this bit in FAQ section of doc as well with a workaround on what config might be needed, if users still want to depend on log4j to figure out class name.
  • Update all the examples here too https://github.com/aws-samples/aws-lambda-powertools-examples which is using logger without specifying a class name-

If you have a proposed update, please share it here

@pankajagrawal16
Copy link
Contributor Author

Thanks to rieckpil for reporting this. @Klosephi will have a look at fixing the docs, FAQ and other bits

@jeromevdl
Copy link
Contributor

@Klosephi, any update on this?

@jeromevdl jeromevdl removed the triage label Jul 9, 2023
@jeromevdl jeromevdl added good-first-issue Good for newcomers priority:2 High - core feature or affects 60% of the users labels Jul 17, 2023
@jreijn
Copy link
Contributor

jreijn commented Jul 21, 2023

@jeromevdl I would like to give this a try if this has not been picked up.

@jeromevdl
Copy link
Contributor

@jreijn, feel free. I think that's an easy one. Just update the doc, have a look at the examples too. And everywhere we use a logger.
Not sure you have to spend much more on this, as we'll rewrite the logging module completely in v2.

@jreijn
Copy link
Contributor

jreijn commented Jul 21, 2023

@jeromevdl yes very simple one, but I wanted to pick an easy one to get started :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation priority:2 High - core feature or affects 60% of the users
Projects
Status: Shipped
Development

No branches or pull requests

5 participants