Skip to content

Maintenance: update docs to use self-hosted mermaid.js script #1719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 2 tasks
dreamorosi opened this issue Aug 26, 2024 · 0 comments · Fixed by #1720
Closed
1 of 2 tasks

Maintenance: update docs to use self-hosted mermaid.js script #1719

dreamorosi opened this issue Aug 26, 2024 · 0 comments · Fixed by #1720
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@dreamorosi
Copy link
Contributor

Summary

We use mermaid for diagrams in a few of our documentation pages and the documentation engine we use defaults to loading the script from a remote CDN.

Why is this needed?

To further improve our security posture we should switch to self hosting the script.

Which area does this relate to?

Other

Solution

Update the mkdocs.yml file and point it to https://docs.powertools.aws.dev/shared/mermaid.min.js

Acknowledgment

@dreamorosi dreamorosi added the documentation Improvements or additions to documentation label Aug 26, 2024
@dreamorosi dreamorosi self-assigned this Aug 26, 2024
@dreamorosi dreamorosi moved this from Triage to Pending review in Powertools for AWS Lambda (Java) Aug 26, 2024
@jeromevdl jeromevdl moved this from Pending review to Shipped in Powertools for AWS Lambda (Java) Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Shipped
Development

Successfully merging a pull request may close this issue.

2 participants
@dreamorosi and others