Default dimension follow Camel Cases

Author: Pankaj Agrawal

powertools-metrics/src/main/java/software/amazon/lambda/powertools/metrics/internal/LambdaMetricsAspect.java

@@ -48,7 +48,7 @@ public Object around(ProceedingJoinPoint pjp,
             MetricsLogger logger = metricsLogger();
 
             logger.setNamespace(namespace(powertoolsMetrics))
-                    .putDimensions(DimensionSet.of("service", service(powertoolsMetrics)));
+                    .putDimensions(DimensionSet.of("Service", service(powertoolsMetrics)));
 
             coldStartSingleMetricIfApplicable(pjp, powertoolsMetrics);
 
@@ -81,7 +81,7 @@ && isColdStart()) {
                 Context context = contextOptional.orElseThrow(() -> new IllegalStateException("Context not found"));
 
                 withSingleMetric("ColdStart", 1, Unit.COUNT, namespace(powertoolsMetrics), (logger) ->
-                        logger.setDimensions(DimensionSet.of("service", service(powertoolsMetrics), "function_name", context.getFunctionName())));
+                        logger.setDimensions(DimensionSet.of("Service", service(powertoolsMetrics), "FunctionName", context.getFunctionName())));
             }
         }
     }

powertools-metrics/src/test/java/software/amazon/lambda/powertools/metrics/internal/LambdaMetricsAspectTest.java

@@ -80,7 +80,7 @@ public void metricsWithoutColdStart() {
 
                         assertThat(logAsJson)
                                 .containsEntry("Metric1", 1.0)
-                                .containsEntry("service", "booking")
+                                .containsEntry("Service", "booking")
                                 .containsKey("_aws");
                     });
         }
@@ -103,15 +103,15 @@ public void metricsWithColdStart() {
                         assertThat(logAsJson)
                                 .doesNotContainKey("Metric1")
                                 .containsEntry("ColdStart", 1.0)
-                                .containsEntry("service", "booking")
+                                .containsEntry("Service", "booking")
                                 .containsKey("_aws");
 
                         logAsJson = readAsJson(s[1]);
 
                         assertThat(logAsJson)
                                 .doesNotContainKey("ColdStart")
                                 .containsEntry("Metric1", 1.0)
-                                .containsEntry("service", "booking")
+                                .containsEntry("Service", "booking")
                                 .containsKey("_aws");
                     });
         }
@@ -134,23 +134,23 @@ public void noColdStartMetricsWhenColdStartDone() {
                         assertThat(logAsJson)
                                 .doesNotContainKey("Metric1")
                                 .containsEntry("ColdStart", 1.0)
-                                .containsEntry("service", "booking")
+                                .containsEntry("Service", "booking")
                                 .containsKey("_aws");
 
                         logAsJson = readAsJson(s[1]);
 
                         assertThat(logAsJson)
                                 .doesNotContainKey("ColdStart")
                                 .containsEntry("Metric1", 1.0)
-                                .containsEntry("service", "booking")
+                                .containsEntry("Service", "booking")
                                 .containsKey("_aws");
 
                         logAsJson = readAsJson(s[2]);
 
                         assertThat(logAsJson)
                                 .doesNotContainKey("ColdStart")
                                 .containsEntry("Metric1", 1.0)
-                                .containsEntry("service", "booking")
+                                .containsEntry("Service", "booking")
                                 .containsKey("_aws");
                     });
         }
@@ -171,7 +171,7 @@ public void metricsWithStreamHandler() throws IOException {
 
                         assertThat(logAsJson)
                                 .containsEntry("Metric1", 1.0)
-                                .containsEntry("service", "booking")
+                                .containsEntry("Service", "booking")
                                 .containsKey("_aws");
                     });
         }
@@ -202,7 +202,7 @@ public void noExceptionWhenNoMetricsEmitted() {
                         Map<String, Object> logAsJson = readAsJson(s);
 
                         assertThat(logAsJson)
-                                .containsEntry("service", "booking")
+                                .containsEntry("Service", "booking")
                                 .doesNotContainKey("_aws");
                     });
         }