Removed some unecessary overrides

Author: scottgerring

powertools-parameters/powertools-parameters-dynamodb/src/main/java/software/amazon/lambda/powertools/parameters/dynamodb/DynamoDbProviderBuilder.java

@@ -14,6 +14,7 @@
 
 package software.amazon.lambda.powertools.parameters.dynamodb;
 
+import java.time.temporal.ChronoUnit;
 import software.amazon.awssdk.core.SdkSystemSetting;
 import software.amazon.awssdk.core.client.config.ClientOverrideConfiguration;
 import software.amazon.awssdk.core.client.config.SdkAdvancedClientOption;
@@ -31,6 +32,10 @@ public class DynamoDbProviderBuilder {
     private CacheManager cacheManager;
     private TransformationManager transformationManager;
 
+    // Allows the user to override default max age
+    private int maxAge;
+    private ChronoUnit unit;
+
     static DynamoDbClient createClient() {
         return DynamoDbClient.builder()
                 .httpClientBuilder(UrlConnectionHttpClient.builder())

powertools-parameters/powertools-parameters-secrets/src/main/java/software/amazon/lambda/powertools/parameters/secrets/SecretsProvider.java

@@ -16,15 +16,13 @@
 
 import static java.nio.charset.StandardCharsets.UTF_8;
 
-import java.time.temporal.ChronoUnit;
 import java.util.Base64;
 import java.util.Map;
 import software.amazon.awssdk.services.secretsmanager.SecretsManagerClient;
 import software.amazon.awssdk.services.secretsmanager.model.GetSecretValueRequest;
 import software.amazon.lambda.powertools.parameters.BaseProvider;
 import software.amazon.lambda.powertools.parameters.cache.CacheManager;
 import software.amazon.lambda.powertools.parameters.transform.TransformationManager;
-import software.amazon.lambda.powertools.parameters.transform.Transformer;
 
 /**
  * AWS Secrets Manager Parameter Provider<br/><br/>
@@ -100,32 +98,6 @@ protected Map<String, String> getMultipleValues(String path) {
         throw new UnsupportedOperationException("Impossible to get multiple values from AWS Secrets Manager");
     }
 
-    /**
-     * {@inheritDoc}
-     */
-    @Override
-    public SecretsProvider defaultMaxAge(int maxAge, ChronoUnit unit) {
-        super.defaultMaxAge(maxAge, unit);
-        return this;
-    }
-
-    /**
-     * {@inheritDoc}
-     */
-    @Override
-    public SecretsProvider withMaxAge(int maxAge, ChronoUnit unit) {
-        super.withMaxAge(maxAge, unit);
-        return this;
-    }
-
-    /**
-     * {@inheritDoc}
-     */
-    @Override
-    public SecretsProvider withTransformation(Class<? extends Transformer> transformerClass) {
-        super.withTransformation(transformerClass);
-        return this;
-    }
 
     // For test purpose only
     SecretsManagerClient getClient() {

powertools-parameters/powertools-parameters-ssm/src/main/java/software/amazon/lambda/powertools/parameters/ssm/SSMProvider.java

@@ -14,7 +14,6 @@
 
 package software.amazon.lambda.powertools.parameters.ssm;
 
-import java.time.temporal.ChronoUnit;
 import java.util.HashMap;
 import java.util.Map;
 import software.amazon.awssdk.services.ssm.SsmClient;
@@ -25,7 +24,6 @@
 import software.amazon.lambda.powertools.parameters.BaseProvider;
 import software.amazon.lambda.powertools.parameters.cache.CacheManager;
 import software.amazon.lambda.powertools.parameters.transform.TransformationManager;
-import software.amazon.lambda.powertools.parameters.transform.Transformer;
 
 /**
  * AWS System Manager Parameter Store Provider <br/><br/>
@@ -109,33 +107,6 @@ public String getValue(String key) {
         return client.getParameter(request).parameter().value();
     }
 
-    /**
-     * {@inheritDoc}
-     */
-    @Override
-    public SSMProvider defaultMaxAge(int maxAge, ChronoUnit unit) {
-        super.defaultMaxAge(maxAge, unit);
-        return this;
-    }
-
-    /**
-     * {@inheritDoc}
-     */
-    @Override
-    public SSMProvider withMaxAge(int maxAge, ChronoUnit unit) {
-        super.withMaxAge(maxAge, unit);
-        return this;
-    }
-
-    /**
-     * {@inheritDoc}
-     */
-    @Override
-    public SSMProvider withTransformation(Class<? extends Transformer> transformerClass) {
-        super.withTransformation(transformerClass);
-        return this;
-    }
-
     /**
      * Tells System Manager Parameter Store to decrypt the parameter value.<br/>
      * By default, parameter values are not decrypted.<br/>

powertools-parameters/src/main/java/software/amazon/lambda/powertools/parameters/BaseProvider.java

@@ -69,7 +69,7 @@ public BaseProvider(CacheManager cacheManager, TransformationManager transformat
      * @param unit   Unit of time
      * @return the provider itself in order to chain calls (eg. <pre>provider.defaultMaxAge(10, SECONDS).get("key")</pre>).
      */
-    protected BaseProvider defaultMaxAge(int maxAge, ChronoUnit unit) {
+    public BaseProvider defaultMaxAge(int maxAge, ChronoUnit unit) {
         Duration duration = Duration.of(maxAge, unit);
         cacheManager.setDefaultExpirationTime(duration);
         return this;